This is a large part of why we need to move the clearcase configuration out
into a .reviewboardrc...

What you could do now is modify postreview.py so that the CVSClient instance
is created before the ClearCaseClient. That would guarantee that CVS would
check first.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Jan 18, 2010 at 1:30 PM, David McCloskey <davemcclos...@gmail.com>wrote:

> I'm in a directory with a checkout trying to do a post-review with
> CVS, but post-review is tripping up on a clearcase check:
>
> >>> svn info
> >>> git rev-parse --git-dir
> >>> cleartool pwv -short
> >>> repository info: Path: /view/DEFAULT/vobs/, Base path:
> /view/DEFAULT/vobs/, Supports changesets: False
> Traceback (most recent call last):
>  File "/users/mcclosdl/proj/reviewboard/bin/post-review", line 8, in
> <module>
>    load_entry_point('RBTools==0.2beta2', 'console_scripts', 'post-
> review')()
>  File "/users/mcclosdl/proj/reviewboard/lib/python2.6/site-packages/
> RBTools-0.2beta2-py2.6.egg/rbtools/postreview.py", line 2506, in main
>    repository_info)
>  File "/users/mcclosdl/proj/reviewboard/lib/python2.6/site-packages/
> RBTools-0.2beta2-py2.6.egg/rbtools/postreview.py", line 965, in
> diff_between_revisions
>    return self.do_diff(rev_str)
>  File "/users/mcclosdl/proj/reviewboard/lib/python2.6/site-packages/
> RBTools-0.2beta2-py2.6.egg/rbtools/postreview.py", line 981, in
> do_diff
>    onam = params.pop(0)
> AttributeError: 'str' object has no attribute 'pop'
>
>
> Is there a way to force post-review to use cvs?  Or do I need to do
> some kind of hack?
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to