seacgmk wrote:
I've recently set up ReviewBoard with Perforce configured for pre-
commits.  Perforce allows source files to be checked out by multiple
developers at the same time.  If one developer submits a file for
review and then a second developer checks in their changes to the same
file before the code reviewer has had a chance to look at the first
developers changes, the diff will be out of date.  The diff stored in
ReviewBoard uses the rev of the source code in Perforce at the time
the review was submitted.  Is there any workaround for this
situation?  Is there any way for ReviewBoard to at least flag the
reviewer that they're not reviewing the latest revision of the source
code from source control.  Or maybe have ReviewBoard notify the
developer that they need to resolve changes and re-submit the file for
review?



Not at the moment.

If it were me I would add this to postreview rather than Reviewboard. I've not used p4 but I've used p2; p2 has a "need" command to check for new files, I suspect it would probably be fairly easy to do and quick.

Having Reviewboard check that the version being reviewed is the latest is certainly something that would be nice to have but it would need to be generic and would probably need a lot of thought to cover all the different SCMs (it may be more appropriate do this via the plug-in architecture that Christian has mentioned will be available for later releases of RB).

Chris

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to