Hmm.. Very hard to say. They certainly look identical.

What version of Review Board is this? I believe the 1.1 nightlies have some
additional server-side logging for these errors, but either way, it might be
worth instrumenting the server to find out where exactly it's failing. Take
a look at the new_diff function in reviewboard/webapi/json.py. Add some
logging to the various exception handlers. In the 1.1 nightlies at least,
this has been added to the generic Exception handle:

    logging.error("Error uploading new diff: %s", e, exc_info=1)

If not there, then in the UploadDiffForm in reviewboard/reviews/forms.py and
reviewboard/diffviewer/forms.py.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Feb 1, 2010 at 4:41 AM, Jan Koprowski <jan.koprow...@gmail.com>wrote:

> I made experiment. I create very simple svn repository on linux and
> try use post-review for it on Windows and on Linux. What I get:
>
> On Linux:
>
> >>> HTTP POSTing to
> http://192.168.56.2/api/json/reviewrequests/11/diff/new/: {'basedir': '/'}
> --127.0.1.1.1000.2795.1265030375.375.2
> Content-Disposition: form-data; name="basedir"
>
> /
> --127.0.1.1.1000.2795.1265030375.375.2
> Content-Disposition: form-data; name="path"; filename="diff"
>
> Index: /b
> ===================================================================
> --- /b  (revision 0)
> +++ /b  (revision 0)
> @@ -0,0 +1 @@
> +b
>
> --127.0.1.1.1000.2795.1265030375.375.2--
>
>
> {'path': {'content': 'Index: /b
> \n===================================================================
> \n--- /b\t(revision 0)\n+++ /b\t(revision 0)\n@@ -0,0 +1 @@\n+b\n',
> 'filename': 'diff'}}
> Review request #11 posted.
>
> http://192.168.56.2/r/11
>
>
> On Windows:
>
> >>> HTTP POSTing to http://localhost/api/json/reviewrequests/55/diff/new/:
> {'basedir': '/'}
> --172.28.38.102.1.6644.1265026662.057.3
> Content-Disposition: form-data; name="basedir"
>
> /
> --172.28.38.102.1.6644.1265026662.057.3
> Content-Disposition: form-data; name="path"; filename="diff"
>
> Index: /b
> ===================================================================
> --- /b  (revision 0)
> +++ /b  (revision 0)
> @@ -0,0 +1 @@
> +b
>
> --172.28.38.102.1.6644.1265026662.057.3--
>
>
> {'path': {'content': 'Index: /b
> \n===================================================================
> \n--- /b\t(revision 0)\n+++ /b\t(revision 0)\n@@ -0,0 +1 @@\n+b\n',
> 'filename': 'diff'}}
> Error uploading diff: One or more fields had errors (105)
> >>> {'fields': {'path': ['diff']}, 'stat': 'fail', 'err': {'msg': 'One or
> more fields had errors', 'code': 105}}
> Your review request still exists, but the diff is not attached.
>
> What is the problem? Why this same diff works fine on Linuks and break
> on Windows? What is the change? I don't see any big change in
> generated output.
>
> Greetings from Poland!
> --
> Jan Koprowski
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to