One more thing..
How to fix the issue of post-review can not find the branches
correctly?
As I mentioned you earlier, i have find/replace master branch to donut
in postreview.py  to get to this point.
If I don't do that I get different set of errors.

Thanks for your help.
Kunjal


On Feb 2, 3:56 pm, Christian Hammond <chip...@chipx86.com> wrote:
> Hmm okay, well at least it's talking to the server now. If you check your
> server log file, you should be able to see some exception information that
> says what's generated that 500 error. If not, then temporarily setting DEBUG
> = True in your site's conf/settings_local.py will display that exception
> information in place of the 500 error. Either way, that should help to
> figure out where it's failing and hopefully what's going wrong.
>
> One thing that could be causing it, though, is your Review Board repository
> entry for your Git repository. Do you have it just referencing your remote
> git:// URL, or is Path actually pointing to a local Git checkout? There's no
> concept of grabbing individual files from a remote Git repository, so you
> need either a local clone accessible by Review Board, or if you're using the
> 1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
> raw file from a Git web front-end such as cgit or gitweb.
>
> Unless the Git guys someday extend the protocol to fetch an individual file
> by revision from an upstream repository without a local checkout, this is
> the best we can do.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Feb 2, 2010 at 3:20 PM, Kunjal <kunjal.par...@gmail.com> wrote:
> >  If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
> > It looks like the URL is correct now. But I am still getting error.
> > mob-rb-test{kaparikh}22: postreview.py -d
> > >>> svn info
> > >>> git rev-parse --git-dir
> > >>> git svn info
> > >>> git svn --version
> > >>> git config --get svn-remote.svn.url
> > >>> git remote show origin
> > >>> repository info: Path: git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
> > Supports changesets: False
> > >>> git config --get reviewboard.url
> > >>> git diff --no-color --full-index donut
> > >>> Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
> > /home/kaparikh/.post-review-cookies.txt
> > >>> Loaded valid cookie -- no login required
> > >>> Attempting to create review request for None
> > _make_url: path = api/json/reviewrequests/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/:
> > {'repository_path': 'git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git'}
> > >>> Review request created
> > >>> Uploading diff, size: 867
> > _make_url: path = api/json/reviewrequests/30/diff/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/:
> > {}
> > >>> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> >  "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
>
> > <html xmlns="http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
> >  <head>
> >  <title>500 - Internal Server Error | Review Board</title>
> >  </head>
> >  <body>
> >  <h1>Something broke! (Error 500)</h1>
> >  <p>
> >   It appears something broke when you tried to go to here. This is
> > either
> >   a bug in Review Board or a server configuration error. Please
> > report
> >   this to your administrator.
> >  </p>
> >  </body>
> > </title>
>
> > Unable to access
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/.
> > The host path may be invalid
> > HTTP Error 500: Internal Server Error
>
> > ###########################################################################­#############
>
> > Also, I get up to above error by replacing master branch to donut in
> > the post-review.py script.
> > If I do not change this, I get different error which is like:
>
> > [[
>
> > mob-rb-test{kaparikh}30: postreview.py -d
> > >>> svn info
> > >>> git rev-parse --git-dir
> > >>> git svn info
> > >>> git svn --version
> > >>> git config --get svn-remote.svn.url
> > >>> git remote show origin
> > >>> repository info: Path: git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
> > Supports changesets: False
> > >>> git config --get reviewboard.url
> > >>> git diff --no-color --full-index master
> > Failed to execute command: ['git', 'diff', '--no-color', '--full-
> > index', 'master']
> > fatal: ambiguous argument 'master': unknown revision or path not in
> > the working tree.
> > Use '--' to separate paths from revisions
>
> >  ]]
>
> > On Jan 28, 3:05 pm, Christian Hammond <chip...@chipx86.com> wrote:
> > > You shouldn't need to set REVIEWBOARD_URL in postreview.py. It's pretty
> > much
> > > intended for when there's no alternate way to configure the URL and a
> > > company wants to set a single URL company-wide. However, a much better
> > > option is either the per-repository configuration (such as using git
> > config)
> > > or the .reviewboardrc file. If you set REVIEWBOARD_URL, it will override
> > the
> > > other configuration types.
>
> > > I will point out that in the future, postreview.py will require other
> > code
> > > in RBTools, so copying out postreview.py won't work. Probably after the
> > 0.2
> > > release.
>
> > > At this point, I'd say we should add some debugging information to
> > > postreview.py. Search for the _make_url function, and change it to:
>
> > >     print "_make_url: path = %s" % path
> > >     app = urlparse(self.url)[2]
>
> > >     print "_make_url: app = %s" % app
> > >     if path[0] == '/':
> > >         url = urljoin(self.url, app[:-1] + path)
> > >     else:
> > >         url = urljoin(self.url, app + path)
> > >     print "_make_url: joined URL = %s" % url
>
> > >     if not url.startswith('http'):
> > >         url = 'http://%s' % url
>
> > >     print "_make_url: Resulting URL = %s" % url
> > >     return url
>
> > > That'll hopefully help us see where it's going wrong.
>
> > > Christian
>
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.reviewboard.org
> > > VMware, Inc. -http://www.vmware.com
>
> > > On Thu, Jan 28, 2010 at 9:49 AM, Kunjal <kunjal.par...@gmail.com> wrote:
> > > > Here is what I did.
>
> > > > 1. I did download RB Tools nightly ( RBTools-0.2beta3.dev-20100125 )
> > > > in to my windows machine.
> > > > 2. I modify REVIEWBOARD_URL in post-review.py. That is the all change
> > > > I did.
> > > > 3. I copy post.review.py to linux box. ( I am not sure whether
> > > > complete RB Tools needs install or only copy of post-review.py from RB
> > > > Tools is necessary)
> > > > 4. I clone the git repository.
> > > > 5. I configure new repo. in RB Web Admin. (Repository Path =
> > > > git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git/)
> > > > 6. I perform command git config reviewboard.url
> > > >http://mob-rb-test.sj.broadcom.com
> > > > in the git repository.
> > > > 7. post-review.py --parent=donut (vendor.git does have donut branch) --
> > > > > This does not work. It gives host path may be invalid error. Also
> > > > the post-review script is looking at by default to master branch only
> > > > and complains that it can not perform git diff.
> > > > 8  I also try post-review.py --server=http://mob-rb-
> > > > test.sj.broadcom.com and the same thing.
>
> > > > What wrong I am doing here?
>
> > > > Kunjal
>
> > > > On Jan 27, 2:19 pm, Christian Hammond <chip...@chipx86.com> wrote:
> > > > > I've tried to reproduce this in my version of post-review and I
> > can't.
> > > > Are
> > > > > you running a fully upstream version of RBTools now, or is it at all
> > > > custom?
>
> > > > > Also, what version of Python are you running?
>
> > > > > Christian
>
> > > > > --
> > > > > Christian Hammond - chip...@chipx86.com
> > > > > Review Board -http://www.reviewboard.org
> > > > > VMware, Inc. -http://www.vmware.com
>
> > > > > On Wed, Jan 27, 2010 at 2:12 PM, Kunjal <kunjal.par...@gmail.com>
> > wrote:
> > > > > > Any pointers?
>
> > > > > > On Jan 26, 9:55 am, Kunjal <kunjal.par...@gmail.com> wrote:
> > > > > > > Here is my config looks like:
>
> > > > > > > [core]
> > > > > > >         repositoryformatversion = 0
> > > > > > >         filemode = true
> > > > > > >         bare = false
> > > > > > >         logallrefupdates = true
> > > > > > > [remote "origin"]
> > > > > > >         url = git://
> > > > > > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git
> > > > > > >         fetch = +refs/heads/*:refs/remotes/origin/*
> > > > > > > [branch "donut"]
> > > > > > >         remote = origin
> > > > > > >         merge = refs/heads/donut
> > > > > > > [reviewboard]
> > > > > > >         url =http://mob-rb-test.sj.broadcom.com
>
> > > > > > > I also try alternative config as:
>
> > > > > > > [core]
> > > > > > >         repositoryformatversion = 0
> > > > > > >         filemode = true
> > > > > > >         bare = false
> > > > > > >         logallrefupdates = true
> > > > > > > [remote "origin"]
> > > > > > >         url = git://
> > > > > > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git
> > > > > > >         fetch = +refs/heads/*:refs/remotes/origin/*
> > > > > > > [branch "donut"]
> > > > > > >         remote = origin
> > > > > > >         merge = refs/heads/donut
>
> > > > > > > But same result.
>
> > > > > > > On Jan 25, 5:27 pm, Christian Hammond <chip...@chipx86.com>
> > wrote:
>
> > > > > > > > Hmm, that doesn't look good. What does the Git config look
> > like?
>
> > > > > > > > Christian
>
> > > > > > > > --
> > > > > > > > Christian Hammond - chip...@chipx86.com
> > > > > > > > Review Board -http://www.reviewboard.org
> > > > > > > > VMware, Inc. -http://www.vmware.com
>
> > > > > > > > On Mon, Jan 25, 2010 at 11:07 AM, Kunjal <
> > kunjal.par...@gmail.com>
> > > > > > wrote:
> > > > > > > > > Hello,
>
> > > > > > > > > When I post-review for GIT, I am getting below error.
>
> > > > > > > > > somehow the host path is listing ReviewBoard URL two times as
> > you
> > > > can
> > > > > > > > > see below.
>
> ...
>
> read more »- Hide quoted text -
>
> - Show quoted text -

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to