Patch submitted as http://reviews.reviewboard.org/r/1393/
The change was almost too simple. I only updated documentation and changed the logic that verifies the options have been specified correctly. -Luke On Feb 5, 4:12 pm, Christian Hammond <chip...@chipx86.com> wrote: > Hi Luke, > > The --repository-url parameter was implemented for the purpose of > post-commit support. It was also before the addition of --diff-filename (a > very recent option). I'd be more than happy to have support for > --diff-filename with --repository-url. We'll likely need a patch for it, > though, as I won't have any time in the near future to implement it (will be > out of town). > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > On Fri, Feb 5, 2010 at 1:28 PM, LukeRobison <lukerobi...@gmail.com> wrote: > > > First off, I'm using svn on linux. Second, google seems to refuse to > > let me search this newsgroup (500: server error), so I apologize if > > this question has been asked before/recently. > > > I'm attempting to use the post-review tool to upload diff files from > > outside a working copy. I tried to simply use the "--diff-filename" > > option, but this resulted in the complaint that my current directory > > doesn't contain a supported repository. Adding the "--repository-url" > > option complains that I'm required to specify a revision range. At > > this point I think post-review thinks I'm attempting to do a post- > > commit review because it seems to ignore my supplied diff file and try > > to generate its own based on the revision or revisions I supply to > > it. Is there no way to simply upload a diff and claim that it should > > apply to a certain directory as is done when using the web interface? > > > Thanks for any help, > > -Luke > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~----------~----~----~----~------~----~------~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
