Thanks. I got confused between revisions and changesets, especially as I develop stuff using Mercurial, while the other developers use SVN!
I'm curious why I can't create a review request via the json api with the revision numbers as parameters. I guess I assumed review board would then extract the diff from SVN. I'm trying to create an SVN post-commit hook that generates the review request. So what's the best/optimal way to do this? Should I spawn the diff tool and then hand off the resultant file to review board? Thanks On Feb 5, 5:44 pm, Christian Hammond <chip...@chipx86.com> wrote: > Revisions are solely interpreted from the diff. So long as the files in the > diff reference the proper revisions, it should work. > > Changesets are an entirely different thing. They're Perforce-only. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > On Fri, Feb 5, 2010 at 10:56 AM, Stodge <sto...@gmail.com> wrote: > > Is it possible to specify a change number/revision for an SVN > > repository when creating a review request via json? I'm guessing not > > but I wanted to check. > > > ERROR:root:Exception thrown for user admin at > >http://localhost:9900/reviews/api/json/reviewrequests/new/ > > > Traceback (most recent call last): > > File "/usr/lib/python2.5/site-packages/django/core/handlers/ > > base.py", line 92, in get_response > > response = callback(request, *callback_args, **callback_kwargs) > > File "/usr/lib/python2.5/site-packages/django/views/decorators/ > > cache.py", line 44, in _wrapped_view_func > > response = view_func(request, *args, **kwargs) > > File "/usr/lib/python2.5/site-packages/Djblets-0.5.6-py2.5.egg/ > > djblets/webapi/decorators.py", line 59, in _checklogin > > response = view_func(request, *args, **kwargs) > > File "/usr/lib/python2.5/site-packages/django/views/decorators/ > > http.py", line 37, in inner > > return func(request, *args, **kwargs) > > File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/ > > reviewboard/webapi/json.py", line 439, in new_review_request > > user, repository, request.POST.get('changenum', None)) > > File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/ > > reviewboard/reviews/managers.py", line 73, in create > > review_request.update_from_changenum(changenum) > > File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/ > > reviewboard/reviews/models.py", line 342, in update_from_changenum > > update_obj_with_changenum(self, self.repository, changenum) > > File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/ > > reviewboard/reviews/models.py", line 36, in update_obj_with_changenum > > changeset = repository.get_scmtool().get_changeset(changenum) > > File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/ > > reviewboard/scmtools/core.py", line 65, in get_changeset > > raise NotImplementedError > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~----------~----~----~----~------~----~------~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
