I spent some time on review.source.android.com a bit earlier and you're right, it's much snappier.
I'm going to spend some time looking into what the slowdowns are. Part of it may be due to the Django templating. Part of it is likely Pygments syntax highlighting. I'll spend some time poking around and seeing what Gerrit does and where our bottlenecks are after this release starts to wrap up. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Mar 10, 2010 at 5:56 PM, Dan Savilonis <d...@n-cube.org> wrote: > I think it's just a general performance comparison, though initial > diff loading is particularly slow. I haven't profiled it, but if you > compare loading reviews.reviewboard.org dashboard to > review.source.android.com, or one of the diffs, the latter just feels > much more instantaneous. I don't know how much of that is due to > caching, network latency, javascript, server-side, etc but faster is > always better :) So one part of this is just gathering some profiling > data and comparing. > > On Mar 10, 4:37 pm, Christian Hammond <chip...@chipx86.com> wrote: > > Agreed on both parts. > > > > There's a bit more that Review Board does than Gerrit and Rietveld under > the > > hood, but we should certainly strive to make things faster. Is there a > > specific area where Review Board feels slower to you? > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > > > > > > On Wed, Mar 10, 2010 at 1:32 PM, Dan Savilonis <d...@n-cube.org> wrote: > > > I would generalize Stephen's idea and just call it general support for > > > distributed vcs workflow since RB isn't really built around that model > > > and we're kind of stuffing it in after the fact. > > > > > I'd also love to see performance improvements. I haven't done any real > > > comparisons, but Rietveld and Gerrit just seem much more lightweight > > > and snappy. > > > > > Dan > > > > > On Mar 9, 10:03 pm, Stephen Gallagher <step...@gallagherhome.com> > > > wrote: > > > > It was discussed in another thread, but I think it would be great to > > > improve > > > > the git support by handling patch-sets in post-review. > > > > > > The idea would be to support the following workflow: > > > > > > Create a branch based on the upstream master (the repository that RB > is > > > > storing). > > > > Apply several patches on that branch, each dependent on the others. > > > > post-review should be capable of automatically generating a review > (using > > > > --guess-summary and --guess-description) for every patch since the > > > > divergence from upstream, properly handling the linking to a parent > diff. > > > > > > On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond < > chip...@chipx86.com > > > >wrote: > > > > > > > Hi everyone, > > > > > > > We've signed up again this year to take part in Google's Summer of > > > Code. > > > > > We're still awaiting acceptance, but want to brainstorm some ideas > that > > > > > students can work on. > > > > > > > First of all, for those who aren't familiar with this, Google > Summer of > > > > > Code is a yearly program from Google where students from around the > > > world > > > > > are paid to work on open source projects. We participated as an > > > organization > > > > > last year and received some awesome features (some of which are > going > > > in to > > > > > 1.5, some of which are going into 1.6). > > > > > > > We're hoping for 3 or 4 students this year. We have a list of ideas > ( > > > > >http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd > like > > > > > feedback on. If you have something you think would be generally > useful > > > to > > > > > Review Board users that you'd like to see on this list and think > would > > > be a > > > > > good project, please tell us! > > > > > > > Also, if you're someone with a fair amount of experience with the > > > Review > > > > > Board codebase, let us know if you'd be interested in helping > mentor a > > > > > student this year. It's purely volunteer work, and can be > > > time-consuming, > > > > > but it's also an excellent way to help out the project and get some > > > cool new > > > > > features in the codebase. > > > > > > > Christian > > > > > > > -- > > > > > Christian Hammond - chip...@chipx86.com > > > > > Review Board -http://www.reviewboard.org > > > > > VMware, Inc. -http://www.vmware.com > > > > > > > -- > > > > > Want to help the Review Board project? Donate today at > > > > >http://www.reviewboard.org/donate/ > > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > > -~----------~----~----~----~------~----~------~--~--- > > > > > To unsubscribe from this group, send email to> > > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > <reviewboard%2bunsubscr...@googlegr oups.com>> < > reviewboard%2bunsubscr...@googlegroups.com<reviewboard%252bunsubscr...@googlegroups.com> > <reviewboard%252bunsubscr...@goo glegroups.com> > > > > > > > For more options, visit this group at > > > > >http://groups.google.com/group/reviewboard?hl=en > > > > > -- > > > Want to help the Review Board project? Donate today at > > >http://www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~----------~----~----~----~------~----~------~--~--- > > > To unsubscribe from this group, send email to> > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > <reviewboard%2bunsubscr...@googlegr oups.com> > > > For more options, visit this group at > > >http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
