This is really part of a larger issue.

I have a branch (it's old now) sitting around that collapses old reviews
that you haven't seen that are older than the latest change to the review
request. The idea being that you only by default see what's new. If we did
this, then we'd also want to modify the comment column to reflect the most
recent diff as well.

There were some issues with my patch. I believe some caching-related issues.
It could be sorted out, but I want to think more about all this, and figure
out how much of the page to build server-side and how much to build
client-side.

Before modifying the comment column, I think we need a good design for all
this, so we're at least semi-consistent.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Mar 22, 2010 at 9:02 AM, Scott Quesnelle
<scott.quesne...@gmail.com>wrote:

> The only downside to the 'My comments' column is that it doesn't get reset
> if a new revision of a diff is posted.
> But it helps see if you have commented at all. A list of reviews that you
> haven't given a ship it to the current diff would be useful.
>
> Scott
>
>
> On Mon, Mar 22, 2010 at 12:41 AM, Christian Hammond 
> <chip...@chipx86.com>wrote:
>
>> Hi,
>>
>> There are definitely things we should be looking into for improving the
>> dashboard in the future.
>>
>> As far as the first request, check out the extra columns (the "..." to the
>> right of the columns in the dashboard). You can add the "My Comments" column
>> to show which ones you've commented on (and whether you've marked Ship It)
>> and which ones you haven't.
>>
>> There are other useful columns in there that can help track information.
>>
>>
>> Christian
>>
>> --
>> Christian Hammond - chip...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>> 2010/3/21 qhlonline <qhlonl...@163.com>
>>
>> Hi, all
>>>    Some users complain that there operation on Reviewboard is not so
>>> convinent. for example: Some people as reviewer want to konw "Which
>>> ReviewRequests are that I have not ShipIt", "Which ReviewRequest are newly
>>> coming ReviewRequest" "After I had reviewed or shipIt, What other Reviewers
>>> had said about this ReviewRequest". Though those information can be got at
>>> last, but Reviewers want to get such infomation on the Dashboard, Is there
>>> any RR filter on the Dashboard so that only user wanted ReviewRequests are
>>> listed ?
>>>
>>>
>>>
>>> Best Regards!
>>>
>>>
>>>  --
>>> Want to help the Review Board project? Donate today at
>>> http://www.reviewboard.org/donate/
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> -~----------~----~----~----~------~----~------~--~---
>>> To unsubscribe from this group, send email to
>>> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
>>> For more options, visit this group at
>>> http://groups.google.com/group/reviewboard?hl=en
>>>
>>> To unsubscribe from this group, send email to reviewboard+
>>> unsubscribegooglegroups.com or reply to this email with the words
>>> "REMOVE ME" as the subject.
>>>
>>
>>  --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~----------~----~----~----~------~----~------~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>>
>> To unsubscribe from this group, send email to reviewboard+
>> unsubscribegooglegroups.com or reply to this email with the words "REMOVE
>> ME" as the subject.
>>
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
> To unsubscribe from this group, send email to reviewboard+
> unsubscribegooglegroups.com or reply to this email with the words "REMOVE
> ME" as the subject.
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

To unsubscribe from this group, send email to 
reviewboard+unsubscribegooglegroups.com or reply to this email with the words 
"REMOVE ME" as the subject.

Reply via email to