I do realize performance could be a concern so I know this wouldn't be
for everyone and it would have to be a setting. But for teams that are
small enough (server load) and ones that don't send huge chunks of
code I think this would be great. One suggestion would be to limit the
size of the email and truncate after that but I realize that may be
additional work. It does seem like having templates or the ability to
customize each email would make this easy to customize.
On May 14, 1:11 am, Christian Hammond <chip...@chipx86.com> wrote:
> Hi Jon,
> Including the full diff could certainly lead to overly large e-mails in many
> setups. For example, on a project I've been doing lately, I've had changes
> that spanned over 60 files with thousands of inserts, deletes and replaces.
> This would make for really long e-mails, which could increase the load on
> Review Board and the mail server.
> The e-mail today includes a link to the diff viewer. We could include a link
> to the raw diff as well. Would that be sufficient?
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
> On Thu, May 13, 2010 at 8:42 PM, Jon <wuservi...@gmail.com> wrote:
> > I just setup 1.5 beta 2 with Mercurial and postreview extension and
> > it's working pretty well. However, one thing that people in my group
> > are asking for is a full diff of the entire commit with the diff list
> > in the publish email.
> > I've seen that RB does this when you do a code review so is it easy to
> > make it send the full diffs all the time?
> > I realize they could be big but we tend to do smaller commits and
> > we've been sending out text diffs by email this whole time anyways.
> > Thanks!
> > --
> > Want to help the Review Board project? Donate today at
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~----------~----~----~----~------~----~------~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegr
> > oups.com>
> > For more options, visit this group at
> Want to help the Review Board project? Donate today
> Happy user? Let us know athttp://www.reviewboard.org/users/
> To unsubscribe from this group, send email to
> For more options, visit this group
Want to help the Review Board project? Donate today at
Happy user? Let us know at http://www.reviewboard.org/users/
To unsubscribe from this group, send email to
For more options, visit this group at