Christian,

That's precisely the jQuery UI's widget that I mentioned.
I can refactor the one I'm writing for the stacked patches (aka
bundle), and put that in the trunk in time for 1.6.

I'll work on this.

Cheers,

Eduardo.

On Fri, Aug 20, 2010 at 3:46 PM, Christian Hammond <chip...@chipx86.com> wrote:
> When we first implemented this, we knew it was ugly, and had considered it a
> sort of temporary stop-gap. But then Review Board got popular and people had
> more pressing concerns, bug and feature-wise. So we never quite got around
> to it.
>
> What I've considered is a widget that shows all revisions and lets you
> select a range between them. For example:
>
>  1  2  3  4  5
> |---o=====o----|
>
> The idea being that you could drag each handle to the revision you care
> about, and then hit a button.
>
> There's a jQuery widget for doing just this that I found recently. While I
> don't really have time scheduled in 1.6 for this, maybe I or someone else
> can play around with it and replace what we have today.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Fri, Aug 20, 2010 at 10:36 AM, Eduardo Felipe <eduardofelip...@gmail.com>
> wrote:
>>
>> Geoffrey,
>>
>> It was part of my Summer of Code to implement a similar (in concept at
>> least) interface, and I ran into a question about how to do this
>> properly, and I think a range selector is the best possible solution,
>> but they are hard to implement, even when using jQuery UI's range
>> selector, so I'm working on that.
>>
>> Note that currently RB does not show a cumulative patch, only a
>> version and a difference between versions. It will show cumulative
>> patches, as that was part of SoC as well, but the feature is for
>> inclusion in a future version of ReviewBoard.
>>
>> But no matter how newbie you are, I would really encourage you to post
>> your code to http://reviews.reviewboard.org, so I can check it out and
>> discuss this further.
>>
>> Cheers,
>>
>> Eduardo Felipe.
>>
>> On Fri, Aug 20, 2010 at 1:24 PM, Geoffrey Zheng <geoffreyzh...@yahoo.com>
>> wrote:
>> > Screenshot is uploaded as rb.png
>> >
>> > http://reviewboard.googlegroups.com/web/rb.png?gsc=iBqKOxYAAABgpEsrTenpw2OJ9ZY_yaTfM9KWFkvR1kwtm4g5T1-szg
>> >
>> > --
>> > Want to help the Review Board project? Donate today at
>> > http://www.reviewboard.org/donate/
>> > Happy user? Let us know at http://www.reviewboard.org/users/
>> > -~----------~----~----~----~------~----~------~--~---
>> > To unsubscribe from this group, send email to
>> > reviewboard+unsubscr...@googlegroups.com
>> > For more options, visit this group at
>> > http://groups.google.com/group/reviewboard?hl=en
>>
>> --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~----------~----~----~----~------~----~------~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to