I'm definitely a Python noob, but don't mind digging around in the
code.  I'm not familiar with python distributions and eggs, I assume I
can just unzip the RBTools egg and then rezip it?  I'll give it a shot
when I have a free moment tomorrow and get back to you.  Thanks again!

tony

On Sep 16, 10:43 pm, Christian Hammond <chip...@chipx86.com> wrote:
> Interesting. That's definitely the problem. post-review expects the version
> information to be entirely numeric.
>
> I don't know what your Python comfort level is, but if you edited
> rbtools/rbtools/postreview.py and found the line that includes "Server
> version: ", and modified it to look like:
>
>     m = re.search(r'^Server version: [^
> ]*/([0-9]+)\.([0-9]+)(\.PATCH)?/[0-9]+ .*$',
>
> It may be work.
>
> That's just off the top of my head. But give it a try and if it works, we
> can include it.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Thu, Sep 16, 2010 at 7:41 PM, Tony <tony.cassan...@gmail.com> wrote:
> > Christian,
>
> > Thanks for the quick response.  I figured as much for the root thing.
> > Realized after I sent the email that p4 wasn't on my path as root, so
> > that explains it anyway...
>
> > In terms of the p4 info the server version line is present:
>
> > Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26)
>
> > The whole thing looks like this (with the personal details removed):
>
> > User name: tony
> > Client name: tony_mac
> > Client host: mybox.local
> > Client root: /folder/source
> > Current directory: /folder/source
> > Client address: 10.100.101.21:53141
> > Server address: perforcesrv1.mydomain.com:1666
> > Server root: /perforce_depot/
> > Server date: 2010/09/16 19:35:27 -0700 PDT
> > Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26)
> > Server license: MyCompany Inc 17 users (support expired 2007/05/16)
>
> > Thanks again!
>
> > tony
>
> > On Sep 16, 6:40 pm, Christian Hammond <chip...@chipx86.com> wrote:
> > > Hi Tony,
>
> > > We discourage running as root, so that wouldn't be it.
>
> > > It's likely that it's failing to parse the server version info. Can you
> > type
> > > `p4 info` and show me the "Server version:" line, if it exists? If it
> > > doesn't, that's useful to know too, and I'd like to know if there's an
> > > equivalent line on there.
>
> > > Christian
>
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.reviewboard.org
> > > VMware, Inc. -http://www.vmware.com
>
> > > On Thu, Sep 16, 2010 at 6:20 PM, Tony <tony.cassan...@gmail.com> wrote:
> > > > Hey everyone,
>
> > > > I'm trying to get ReviewBoard set up.  Installing the server was no
> > > > problem, however I've been having issues with post-review and
> > > > perforce.  I have two problems, the first is clearly a permission
> > > > problem, but I can't seem to find where the python files live to
> > > > change them.  I'm not super familiar with Python so excuse my
> > > > ignorance.
>
> > > > I'm on OS X and running an older (server 2005.2) version of perforce.
>
> > > > The first error is:
> > > > post-review -d
> > > > >>> svn info
> > > > >>> git rev-parse --git-dir
> > > > >>> hg root
> > > > >>> p4 info
> > > > Traceback (most recent call last):
> > > >  File "/usr/local/bin/post-review", line 8, in <module>
> > > >    load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
> > > > ()
> > > >  File "build/bdist.linux-x86_64/egg/rbtools/postreview.py", line
> > > > 2809, in main
> > > >  File "build/bdist.linux-x86_64/egg/rbtools/postreview.py", line
> > > > 2759, in determine_client
> > > >  File "build/bdist.linux-x86_64/egg/rbtools/postreview.py", line
> > > > 1409, in get_repository_info
> > > > AttributeError: 'NoneType' object has no attribute 'group'
>
> > > > When running as root this changes to the following:
> > > > sudo post-review -d
> > > > >>> svn info
> > > > >>> git rev-parse --git-dir
> > > > >>> hg root
> > > > >>> p4 info
> > > > The current directory does not contain a checkout from a
> > > > supported source code repository.
>
> > > > The p4 command line tool is on my path and runs without issue alone.
> > > > Any and all pointers are appreciated.  Or if there's a better place
> > > > for me to ask this, please let me know.  I've tried digging through
> > > > the docs and didn't see anything that might solve the issues.  Clearly
> > > > running the tool as root isn't ideal, but isn't a dealbreaker either.
> > > > Thanks in advance!
>
> > > > tony
>
> > > > --
> > > > Want to help the Review Board project? Donate today at
> > > >http://www.reviewboard.org/donate/
> > > > Happy user? Let us know athttp://www.reviewboard.org/users/
> > > > -~----------~----~----~----~------~----~------~--~---
> > > > To unsubscribe from this group, send email to
> > > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> > <reviewboard%2bunsubscr...@googlegroups.com<reviewboard%252bunsubscr...@googlegroups.com>
>
> > > > For more options, visit this group at
> > > >http://groups.google.com/group/reviewboard?hl=en
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~----------~----~----~----~------~----~------~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to