It's effective at diff generation time, but if you've already viewed the
diff, it's been cached. You would have to restart memcached to see the
effects, and likely clear your browser cache as well.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Oct 14, 2010 at 6:37 AM, cogo <edvartsen.chris...@gmail.com> wrote:

> I'm using 1.5RC1 and in the settings part of the admin area I have
> enabled:
>
> Show syntax highlighting
> Show trailing whitespace
>
> and in the input field for "Show all whitespace for" I have tried *.*,
> *.php and several other combinations. Perhaps these changes are
> effective post-creation of a review? I'm not sure about what these
> values was when the actual review was created.
>
> On Oct 13, 5:36 pm, Chris Clark <chris.cl...@ingres.com> wrote:
> > cogo wrote:
> > > I have just started trying out reviewboard and I have some issues with
> > > some diffs not beeing displayed when I click "View diff" in the review
> > > request. When i download the diff I can see the content:
> >
> > > Index: //trunk/library/extras/global-post-commit-hook.php
> > > ===================================================================
> > > --- //trunk/library/extras/global-post-commit-hook.php     (revision
> 1901)
> > > +++ //trunk/library/extras/global-post-commit-hook.php     (revision
> 1902)
> > > @@ -64,4 +64,4 @@
> > >                   $revision));
> > >  }
> >
> > > -// Test
> > > \ No newline at end of file
> > > +// Test
> >
> > > Why does this not get displayed?
> >
> > This looks like a white-space-only-diff issue. There is a config option
> > that _may_ help here (and there is a bug too), see :
> >
> > <http://code.google.com/p/reviewboard/issues/detail?id=1780>
> http://code.google.com/p/reviewboard/issues/detail?id=1780http://code.google.com/p/reviewboard/issues/detail?id=1511
> >
> > Chris
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to