I can't give a full response to everything here, but if you're using
post-review (likely) then the P4PORT env variable is effectively
ignored.

Instead, post-review runs "p4 info" and pulls the port information from
the "Server address: server.domain.com:1666" line.

It then calls "gethostbyaddr()" on the result and compares the results
to the values on the reviewboard server's repository list.

The reviewboard server contacts the perforce server using the locations
defined in the reviewboard server's repository list and dynamically
generates the diff content every time the diff is viewed.

So, how to optimize this for your users?  I don't know, but I thought
I could shed some light on how it's working to help figure that out :)

Dana Lacoste

-----Original Message-----
From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com]
On Behalf Of Jason Alday
Sent: Wednesday, October 20, 2010 4:16 PM
To: reviewboard
Subject: Review Board with Perforce proxy servers

Hi,

We've recently starting using Review Board for our team but we are
spread out across several sites in the US.  Each site has it's own P4
proxy server that people on that site use for their P4 activity.
Behind the scenes I understand these proxies phone home to master P4
server (which is actually outside the US).  The Review Board server is
actually located in one of these remote sites inside the US, far from
the master P4 server.

>From what we can tell, when the user is using post-review the p4Info
that comes back appears to be the master server that is outside the US
(even though their P4PORT env variable is set to their local proxy)
The repositories for Review Board are also set to the server outside
the US.

It would be ideal if the post-review diff was generated based on the
users local P4 proxy as that would be the fastest.  Then it would be
ideal if the Review Board server used the local proxy for it's
location.  Is this possible?

It's not clear to me how much P4 server contacting the Review Board
server does.  When the user clicks on "View Diff" in Review Board,
does that result in the server contacting the P4 server for any info
or is all of this info stored locally in the Review Board's database
from the submission time?


Thanks,
Jason.

-- 
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to