You can't comment on unpublished diffs. I thought we had fixed the bug
where the UI allows that, but it may have regressed. You'll need to
publish the diff before commenting.

Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Wed, Dec 22, 2010 at 8:02 AM, orzha1 <orz...@gmail.com> wrote:
> Hello, I'm facing a strange issue.When trying to add a comment to the
> code the following occurs:
>
>
> 2010-12-22 17:41:27,912 - DEBUG - Generating diff viewer page for
> filediff id 14
> 2010-12-22 17:41:27,916 - DEBUG - Begin: Generating diff file info for
> diffset id 14
> 2010-12-22 17:41:27,922 - DEBUG - End: Generating diff file info for
> diffset id 14
> 2010-12-22 17:41:27,923 - DEBUG - Generating diff file info for
> diffset id 14 took 0.6501 seconds
> 2010-12-22 17:41:27,930 - DEBUG - Begin: Generating diff file info for
> diffset id 14, filediff 32
> 2010-12-22 17:41:27,932 - INFO - Cache miss for key server:diff-
> sidebyside-hl-32.
> 2010-12-22 17:41:27,948 - INFO - Cache miss for key server:/view/
> user_view/vobs/:/vobs/webos/src/common/link.c%40%40/main/
> submit_cheetah_32490/0:main/submit_cheetah_32490/0.
> 2010-12-22 17:41:27,948 - DEBUG - Begin: Fetching file '/vobs/webos/
> src/common/link.c@@/main/submit_cheetah_32490/0' rmain/
> submit_cheetah_32490/0 from user_view
> 2010-12-22 17:41:28,214 - DEBUG - End: Fetching file '/vobs/webos/src/
> common/link.c@@/main/submit_cheetah_32490/0' rmain/
> submit_cheetah_32490/0 from user_view
> 2010-12-22 17:41:28,219 - DEBUG - Fetching file '/vobs/webos/src/
> common/link.c@@/main/submit_cheetah_32490/0' rmain/
> submit_cheetah_32490/0 from user_view took 0.262796 seconds
> 2010-12-22 17:41:28,240 - DEBUG - Begin: Patching file /vobs/webos/src/
> common/link.c@@/main/submit_cheetah_32490/5
> 2010-12-22 17:41:28,437 - DEBUG - End: Patching file /vobs/webos/src/
> common/link.c@@/main/submit_cheetah_32490/5
> 2010-12-22 17:41:28,442 - DEBUG - Patching file /vobs/webos/src/common/
> link.c@@/main/submit_cheetah_32490/5 took 0.194516 seconds
> 2010-12-22 17:41:29,984 - DEBUG - Begin: Generating diff chunks for
> filediff id 32 (/vobs/webos/src/common/link.c@@/main/
> submit_cheetah_32490/0)
> 2010-12-22 17:41:30,091 - DEBUG - End: Generating diff chunks for
> filediff id 32 (/vobs/webos/src/common/link.c@@/main/
> submit_cheetah_32490/0)
> 2010-12-22 17:41:30,091 - DEBUG - Generating diff chunks for filediff
> id 32 (/vobs/webos/src/common/link.c@@/main/submit_cheetah_32490/0)
> took 0.106811 seconds
> 2010-12-22 17:41:30,350 - DEBUG - End: Generating diff file info for
> diffset id 14, filediff 32
> 2010-12-22 17:41:30,351 - DEBUG - Generating diff file info for
> diffset id 14, filediff 32 took 2.419846 seconds
> 2010-12-22 17:41:30,578 - DEBUG - Done generating diff viewer page for
> filediff id 14
> 2010-12-22 17:41:30,787 - DEBUG - Begin: Generating diff file info for
> diffset id 14, filediff 33
> 2010-12-22 17:41:30,788 - INFO - Cache miss for key server:diff-
> sidebyside-hl-33.
> 2010-12-22 17:41:30,798 - INFO - Cache miss for key server:/view/
> user_view/vobs/:/vobs/webos/src/common/link.h%40%40/main/
> r_cheetah_1.0.0.0_int/r_cheetah_25.0.0.0_port_int/
> submit_cheetah_32490/0:main/r_cheetah_1.0.0.0_int/
> r_cheetah_25.0.04b640732fb035f0ade436d2bbabe4ec9.
> 2010-12-22 17:41:30,799 - DEBUG - Begin: Fetching file '/vobs/webos/
> src/common/link.h@@/main/r_cheetah_1.0.0.0_int/
> r_cheetah_25.0.0.0_port_int/submit_cheetah_32490/0' rmain/
> r_cheetah_1.0.0.0_int/r_cheetah_25.0.0.0_port_int/
> submit_cheetah_32490/0 from dmitryo_test
> 2010-12-22 17:41:30,902 - DEBUG - End: Fetching file '/vobs/webos/src/
> common/link.h@@/main/r_cheetah_1.0.0.0_int/r_cheetah_25.0.0.0_port_int/
> submit_cheetah_32490/0' rmain/r_cheetah_1.0.0.0_int/
> r_cheetah_25.0.0.0_port_int/submit_cheetah_32490/0 from dmitryo_test
> 2010-12-22 17:41:30,904 - DEBUG - Fetching file '/vobs/webos/src/
> common/link.h@@/main/r_cheetah_1.0.0.0_int/r_cheetah_25.0.0.0_port_int/
> submit_cheetah_32490/0' rmain/r_cheetah_1.0.0.0_int/
> r_cheetah_25.0.0.0_port_int/submit_cheetah_32490/0 from dmitryo_test
> took 0.101990 seconds
> 2010-12-22 17:41:30,909 - DEBUG - Begin: Patching file /vobs/webos/src/
> common/link.h@@/main/r_cheetah_1.0.0.0_int/r_cheetah_25.0.0.0_port_int/
> submit_cheetah_32490/1
> 2010-12-22 17:41:31,034 - DEBUG - End: Patching file /vobs/webos/src/
> common/link.h@@/main/r_cheetah_1.0.0.0_int/r_cheetah_25.0.0.0_port_int/
> submit_cheetah_32490/1
> 2010-12-22 17:41:31,039 - DEBUG - Patching file /vobs/webos/src/common/
> link.h@@/main/r_cheetah_1.0.0.0_int/r_cheetah_25.0.0.0_port_int/
> submit_cheetah_32490/1 took 0.122247 seconds
> 2010-12-22 17:41:31,172 - DEBUG - Begin: Generating diff chunks for
> filediff id 33 (/vobs/webos/src/common/link.h@@/main/
> r_cheetah_1.0.0.0_int/r_cheetah_25.0.0.0_port_int/
> submit_cheetah_32490/0)
> 2010-12-22 17:41:31,200 - DEBUG - End: Generating diff chunks for
> filediff id 33 (/vobs/webos/src/common/link.h@@/main/
> r_cheetah_1.0.0.0_int/r_cheetah_25.0.0.0_port_int/
> submit_cheetah_32490/0)
> 2010-12-22 17:41:31,201 - DEBUG - Generating diff chunks for filediff
> id 33 (/vobs/webos/src/common/link.h@@/main/r_cheetah_1.0.0.0_int/
> r_cheetah_25.0.0.0_port_int/submit_cheetah_32490/0) took 0.28230
> seconds
> 2010-12-22 17:41:31,259 - DEBUG - End: Generating diff file info for
> diffset id 14, filediff 33
> 2010-12-22 17:41:31,260 - DEBUG - Generating diff file info for
> diffset id 14, filediff 33 took 0.472228 seconds
> 2010-12-22 17:41:50,223 - ERROR - Exception thrown for user username
> at http://server/api/json/reviewrequests/14/diff/1/file/32/line/2570/comments/
>
> No FileDiff matches the given query.
> Traceback (most recent call last):
>  File "/usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/
> core/handlers/base.py", line 100, in get_response
>    response = callback(request, *callback_args, **callback_kwargs)
>  File "/usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/
> views/decorators/cache.py", line 69, in _wrapped_view_func
>    response = view_func(request, *args, **kwargs)
>  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5.1-py2.4.egg/
> reviewboard/webapi/decorators.py", line 57, in _view
>    response = view_func(*args, **kwargs)
>  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5.1-py2.4.egg/
> reviewboard/webapi/decorators.py", line 25, in _check
>    return view_func(*args, **kwargs)
>  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5.1-py2.4.egg/
> reviewboard/webapi/json.py", line 1262, in diff_line_comments
>    diffset__revision=diff_revision)
>  File "/usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/
> shortcuts/__init__.py", line 90, in get_object_or_404
>    raise Http404('No %s matches the given query.' %
> queryset.model._meta.object_name)
> Http404: No FileDiff matches the given query.
>
> OS is CentOS 5.3 , ReviewBoard 1.5.1, CM software: Clear Case.
>
> Here is my flow:
> 1) running post-review from the command line (generating diffs and
> uploading to the server)
> 2) log in to the Review Board using my browser
> 3) finding appropriate request
> 4) clicking "View Diff" tab - appropriate diff appears properly
> 5) trying to add a comment to the diff and save it - above error
> appears.
>
> In case I "publish" the review request - I'm able to open diff and add
> any comment.
> In case I create a review request by using Review Board and no post-
> review (uploading a diff file manually) - i'm also able to add a
> comment.
>
> Any ideas regarding the issue?
> Is it possible to get more verbose debug output from Review
> Board(currently DEBUG = True) ?
>
> Thank you.
>
> --
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to