Ah, that makes sense.

I'm totally for fixing it. Just didn't understand what the scenario was.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Sat, Jan 22, 2011 at 9:41 PM, Jan Koprowski <jan.koprow...@gmail.com>wrote:

> Christian,
>
>  You can create user in admin-panel and never login to dashboard.
> Just use it as account to send diffs by post-review. Then it is a
> problem.
>
> On Sat, Jan 22, 2011 at 9:42 PM, Christian Hammond <chip...@chipx86.com>
> wrote:
> > In the in-development 1.6 release, it will by default use
> noreply@yourdomain
> > as the e-mail address. This can be changed, but that's implemented now to
> > work around anti-spam measures.
> >
> > I'm not sure what you mean by it failing if an e-mail address is blank.
> We
> > do require that users have e-mail addresses registered, though, and I
> don't
> > expect that will change.
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board - http://www.reviewboard.org
> > VMware, Inc. - http://www.vmware.com
> >
> >
> > On Sat, Jan 22, 2011 at 8:03 AM, Tristan Crockett <tris...@leadkarma.com
> >
> > wrote:
> >>
> >> They actually did start working. The problem is that Reviewboard's
> >> emailing system will completely fail if one of the addresses is blank.
> >> There's no reason why any of our accounts should need email addresses,
> >> as the emails go out to a mailing list. Yes, it wants to populate the
> >> 'from' field, but why not just fallback to the domain's reviewboard
> >> email address?
> >>
> >> On Jan 19, 3:04 pm, David Trowbridge <trowb...@gmail.com> wrote:
> >> > There's no fine-grained control of this. Review Board should send
> email
> >> > whenever anyone clicks "publish", whether it's on a review or a reply
> to
> >> > a
> >> > review. If the latter isn't working, it's possible something is
> broken.
> >> > Can
> >> > you check your httpd logs and see if there are any errors in there?
> >> >
> >> > -David
> >> >
> >> > On Wed, Jan 19, 2011 at 8:41 AM, Tristan Crockett
> >> > <tris...@leadkarma.com>wrote:
> >> >
> >> > > Is there a way to fine-tune the instances when Reviewboard sends
> >> > > emails? Currently it seems to send when review requests are
> generated
> >> > > and when reviews are added, but not when comments are added to
> >> > > reviews. There don't seem to be any configuration options.
> >> >
> >> > > We're using 1.5.2.
> >> >
> >> > > --
> >> > > Want to help the Review Board project? Donate today at
> >> > >http://www.reviewboard.org/donate/
> >> > > Happy user? Let us know athttp://www.reviewboard.org/users/
> >> > > -~----------~----~----~----~------~----~------~--~---
> >> > > To unsubscribe from this group, send email to
> >> > >
> >> > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> <reviewboard%2bunsubscr...@googlegroups.com<reviewboard%252bunsubscr...@googlegroups.com>
> >
> >> > > For more options, visit this group at
> >> > >http://groups.google.com/group/reviewboard?hl=en
> >>
> >> --
> >> Want to help the Review Board project? Donate today at
> >> http://www.reviewboard.org/donate/
> >> Happy user? Let us know at http://www.reviewboard.org/users/
> >> -~----------~----~----~----~------~----~------~--~---
> >> To unsubscribe from this group, send email to
> >> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> >> For more options, visit this group at
> >> http://groups.google.com/group/reviewboard?hl=en
> >
> > --
> > Want to help the Review Board project? Donate today at
> > http://www.reviewboard.org/donate/
> > Happy user? Let us know at http://www.reviewboard.org/users/
> > -~----------~----~----~----~------~----~------~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> > For more options, visit this group at
> > http://groups.google.com/group/reviewboard?hl=en
>
>
>
> --
> ><> Jan Koprowski
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to