Okay, that sounds great :-) Thanks for looking in to this!

--Noah

"Christian Hammond" <chip...@chipx86.com> wrote:

>I'm putting in a fix that checks for .git/svn. Even if it's empty, you
>should be able to just nuke it and then never deal with it again. We'll
>no
>longer run 'git svn info' unless we see it.
>
>I'd rather not go the route of checking the contents just yet, as it's
>possible we'll break some legitimate setup somehow. I think, though,
>that as
>long as you're willing to remove that directory, things will be fixed.
>
>I'm putting out a new RBTools tomorrow.
>
>Christian
>
>-- 
>Christian Hammond - chip...@chipx86.com
>Review Board - http://www.reviewboard.org
>VMware, Inc. - http://www.vmware.com
>
>
>On Fri, Jan 28, 2011 at 4:18 PM, Noah Kantrowitz
><n...@coderanger.net>wrote:
>
>> In my case `git svn info` is actually creating an empty .git/svn, so
>the
>> check would have to be for if there are any files in there I think.
>On our
>> smaller repos it does bail quickly, so I think somewhere it (git svn
>info)
>> must be walking the history and just going through all 5k revs is
>taking a
>> while.
>>
>> --Noah
>>
>> > -----Original Message-----
>> > From: reviewboard@googlegroups.com
>> > [mailto:reviewboard@googlegroups.com] On Behalf Of Christian
>Hammond
>> > Sent: Friday, January 28, 2011 4:16 PM
>> > To: reviewboard@googlegroups.com
>> > Subject: Re: git svn info very slow
>> >
>> > Hi Noah,
>> >
>> > I looked at the git-svn code, and it seems to invoke the migration
>for
>> > certain commands. I didn't see 'info' in the list, but when I ran
>git
>> > svn info on my git-only repository, it went through the same steps,
>but
>> > it did bail really fast.
>> >
>> > I think what we should do is update post-review to only 'git svn
>info'
>> > if it can find a .git/svn directory.
>> >
>> > Christian
>> >
>> > --
>> > Christian Hammond - chip...@chipx86.com
>> > Review Board - http://www.reviewboard.org
>> > VMware, Inc. - http://www.vmware.com
>> >
>> >
>> >
>> > On Fri, Jan 28, 2011 at 3:54 PM, Noah Kantrowitz
><n...@coderanger.net>
>> > wrote:
>> >
>> >
>> >       Just as an update, I updated our internal copy of post-review
>to
>> > just skip
>> >       calling git svn info and now post-review is back to being
>nice
>> > and zippy.
>> >       Still trying to figure out what is causing this though :-)
>> >
>> >
>> >       --Noah
>> >
>> >       > -----Original Message-----
>> >       > From: reviewboard@googlegroups.com
>> >
>> >       > [mailto:reviewboard@googlegroups.com] On Behalf Of Noah
>> > Kantrowitz
>> >       > Sent: Friday, January 28, 2011 2:32 PM
>> >       > To: reviewboard@googlegroups.com
>> >
>> >       > Subject: RE: git svn info very slow
>> >       >
>> >       > Did a search through all of .git for the old server and the
>> > base path
>> >       > ("code/svn") and got no hits. If it is stored compressed in
>> > some
>> >       > metadata
>> >       > somewhere it might not be obvious though :-/ I have found
>> > references to
>> >       > "git
>> >       > svn clone --no-metadata" online, but I think that only
>helps
>> > when doing
>> >       > the
>> >       > initial migration, not later on.
>> >       >
>> >       > --Noah
>> >       >
>> >       > > -----Original Message-----
>> >       > > From: reviewboard@googlegroups.com
>> >       > > [mailto:reviewboard@googlegroups.com] On Behalf Of
>Christian
>> > Hammond
>> >       > > Sent: Friday, January 28, 2011 2:24 PM
>> >       > > To: reviewboard@googlegroups.com
>> >       > > Subject: Re: git svn info very slow
>> >       > >
>> >       > > Huh, I haven't seen that before. There's probably
>something
>> > in .git/
>> >       > > somewhere, but where, I don't know. Maybe grep around for
>> > part of the
>> >       > > repository path?
>> >       > >
>> >       > > I have to run, but I'll play with this a bit and see if I
>can
>> > help
>> >       > > figure it out.
>> >       > >
>> >       > > Christian
>> >       > >
>> >       > > --
>> >       > > Christian Hammond - chip...@chipx86.com
>> >       > > Review Board - http://www.reviewboard.org
>> >       > > VMware, Inc. - http://www.vmware.com
>> >       > >
>> >       > >
>> >       > >
>> >       > > On Fri, Jan 28, 2011 at 2:08 PM, Noah Kantrowitz
>> >       > <n...@coderanger.net>
>> >       > > wrote:
>> >       > >
>> >       > >
>> >       > >     I don't see anything in .git/config about svn (file
>> > attached),
>> >       > > and from a
>> >       > >     fresh clone .git/svn doesn't exist. The first time I
>run
>> > git svn
>> >       > > info it
>> >       > >     prints out the following:
>> >       > >     $ time git svn info
>> >       > >     Migrating from a git-svn v1 layout...
>> >       > >     Data from a previous version of git-svn exists, but
>> >       > >            .git/svn
>> >       > >            (required for this version (1.7.3.1.msysgit.0)
>of
>> > git-svn)
>> >       > > does not
>> >       > >     exist.
>> >       > >     Done migrating from a git-svn v1 layout
>> >       > >
>> >       > >     and then takes 7 minutes to come back with "Unable to
>> > determine
>> >       > > upstream SVN
>> >       > >     information from working tree history". All future
>runs
>> > don't
>> >       > > print the
>> >       > >     migration message (which makes sense), but they still
>> > take
>> >       > > forever. The
>> >       > >     first run does create .git/svn, but it stays empty.
>Is
>> > there
>> >       > > somewhere else
>> >       > >     I should look to de-svn this repo?
>> >       > >
>> >       > >     --Noah
>> >       > >
>> >       > >
>> >       > >     > -----Original Message-----
>> >       > >     > From: reviewboard@googlegroups.com
>> >       > >     > [mailto:reviewboard@googlegroups.com] On Behalf Of
>> > Christian
>> >       > > Hammond
>> >       > >     > Sent: Friday, January 28, 2011 1:50 PM
>> >       > >     > To: reviewboard@googlegroups.com
>> >       > >     > Subject: Re: git svn info very slow
>> >       > >     >
>> >       > >     > Hi Noah,
>> >       > >     >
>> >       > >     > It sounds like the repositories are still
>configured
>> > for git-
>> >       > > svn. If
>> >       > >     > you remove that configuration, the call to git svn
>info
>> > should
>> >       > > fail
>> >       > >     > immediately. It's been a while, but I think this is
>in
>> >       > > .git/config.
>> >       > >     >
>> >       > >     > Christian
>> >       > >     >
>> >       > >     >
>> >       > >     > On Friday, January 28, 2011, Noah Kantrowitz
>> >       > > <n...@coderanger.net>
>> >       > >     > wrote:
>> >       > >     > > We are trying to start using reviewboard with one
>of
>> > our
>> >       > > bigger repos
>> >       > >     > (~5k revs) and we are having a lot of trouble with
>"giv
>> > svn
>> >       > > info".
>> >       > >     > post-review runs this every time to check if the
>> > current repo
>> >       > > is under
>> >       > >     > git-svn control (disclaimer: a lot of those 5k revs
>> > were
>> >       > > migrated from
>> >       > >     > SVN using git-svn, but that was a one-time
>conversion),
>> > and
>> >       > > given that
>> >       > >     > it takes 7 minutes on our main branch, that makes
>post-
>> > review
>> >       > >     > very aggravating. Is there some way to turn this
>check
>> > off
>> >       > > since we
>> >       > >     > know for sure that it will never come back true?
>> > Something in
>> >       > > git
>> >       > >     > config or .reviewboardrc would be ideal so we don't
>> > have to
>> >       > > remember
>> >       > >     > another command-line argument each time. Does this
>> > exist or
>> >       > > should I
>> >       > >     > submit a patch?
>> >       > >     > > --Noah KantrowitzAtari, Inc
>> >       > >     > >
>> >       > >     > >
>> >       > >     > >
>> >       > >     > > --
>> >       > >     > > Want to help the Review Board project? Donate
>today
>> > at
>> >       > >     > http://www.reviewboard.org/donate/
>> >       > >     > > Happy user? Let us know at
>> > http://www.reviewboard.org/users/
>> >       > >     > >
>-~----------~----~----~----~------~----~------~--~---
>> >       > >     > > To unsubscribe from this group, send email to
>> >       > >     >
>reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
>> >
><mailto:reviewboard%2bunsubscr...@googlegroups.com<reviewboard%252bunsubscr...@googlegroups.com>
>> >
>> >       > >
><mailto:reviewboard%2bunsubscr...@googlegroups.com<reviewboard%252bunsubscr...@googlegroups.com>
>> >
><mailto:reviewboard%252bunsubscr...@googlegroups.com<reviewboard%25252bunsubscr...@googlegroups.com>>
>> >
>> >       > >     > > For more options, visit this group at
>> >       > >     > http://groups.google.com/group/reviewboard?hl=en
>> >       > >     >
>> >       > >     > --
>> >       > >     > --
>> >       > >     > Christian Hammond - chip...@chipx86.com
>> >       > >     > Review Board - http://www.reviewboard.org
>> >       > > 

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to