Are you sure this isn't modified code? I don't see that line in the 1.5
release at all.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Feb 22, 2011 at 10:51 AM, Dee <dlit...@yahoo.com> wrote:

> We start running reviewboard 1.5 for our code reviews. One problem
> that throws out from time to time is the "cannot concatenate 'str' and
> 'SpiffyEmailMessage' objects". Below is a portion of the log for this
> error:
>
>
> -----------------------------------------------------------------------------------------------------
>
> 2011-02-22 09:29:24,999 - ERROR - Exception thrown for user yyyy at
> http://xx.xxx.xxx.xx/api/json/reviewrequests/2853/reviews/draft/publish/
>
> cannot concatenate 'str' and 'SpiffyEmailMessage' objects
> Traceback (most recent call last):
>  File "/usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/
> django/core/handlers/base.py", line 100, in get_response
>    response = callback(request, *callback_args, **callback_kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/
> django/views/decorators/cache.py", line 69, in _wrapped_view_func
>    response = view_func(request, *args, **kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-
> py2.6.egg/reviewboard/webapi/decorators.py", line 57, in _view
>    response = view_func(*args, **kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/
> djblets/webapi/decorators.py", line 95, in _checklogin
>    response = view_func(*args, **kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/
> django/views/decorators/http.py", line 37, in inner
>    return func(request, *args, **kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-
> py2.6.egg/reviewboard/webapi/json.py", line 928, in review_draft_save
>    review.publish(user=request.user)
>  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-
> py2.6.egg/reviewboard/reviews/models.py", line 1168, in publish
>    user=user, review=self)
>  File "/usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/
> django/dispatch/dispatcher.py", line 162, in send
>    response = receiver(signal=self, sender=sender, **named)
>  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-
> py2.6.egg/reviewboard/notifications/email.py", line 35, in
> review_published_cb
>    mail_review(user, review)
>  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-
> py2.6.egg/reviewboard/notifications/email.py", line 290, in
> mail_review
>    extra_context)
>  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-
> py2.6.egg/reviewboard/notifications/email.py", line 179, in
> send_review_mail
>    logging.error("Debug e-mail message: " + message)
> TypeError: cannot concatenate 'str' and 'SpiffyEmailMessage' objects
> -------------------------------------------------------------------------
>
> it seems some characters in the review comment or diff content caused
> sending review email to fail, but I can't tell what they are. Can
> anyone tell me how to fix it?
>
> Thanks,
> Dlite
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to