This is a bug that needs to be fixed, but basically you can't make comments
on a diff until the diff is published. We don't really allow comments until
it's published, because the comments would be lost if you discard the diff.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Apr 12, 2011 at 2:19 AM, jh5774....@samsung.com <
jh5774....@samsung.com> wrote:

> Hi,
>
> Sorry, today, I upload my issues many time..;;
>
> Well, anyway,
>
> I find an error when draft status.
>
> 1. create new Review Request.
>
> 2. Now, Review Request's status is draft.
>
> 3. I want to see diff view, so I click the button 'diff views'
>
> 4. I want to comment my source view, (line comment)
>
> Now, there are error appeared.
>
> Below is error message in Web:
>
> Error Code: 404
>
> Error Text: Not Found
>
> Request URL: /reviewboard_demo/api/json/reviewrequests/174/diff/1/file/
> 237/line/6/comments/
>
> Request Data: action=set&num_lines=1&text=%E3%85%85%E3%84%B7+
> %E3%84%B4%E3%85%8B
>
> Response Data:
>
> There may be useful error details below. The following error page may
> be useful to your system administrator or when reporting a bug. To
> save the page, right-click the error below and choose "Save Page As,"
> if available, or "View Source" and save the result as a .html file.
>
> Warning: Be sure to remove any sensitive material that may exist in
> the error page before reporting a bug!
>
>
>
> And, my server log is below:
>
> No FileDiff matches the given query.
> Traceback (most recent call last):
>  File "/usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/
> django/core/handlers/base.py", line 124, in get_response
>    response = callback(request, *callback_args, **callback_kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/
> django/views/decorators/cache.py", line 79, in _wrapped_view_func
>    response = view_func(request, *args, **kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-
> py2.6.egg/reviewboard/webapi/decorators.py", line 61, in _view
>    response = view_func(*args, **kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-
> py2.6.egg/reviewboard/webapi/decorators.py", line 27, in _check
>    return webapi_login_required(view_func)(*args, **kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
> djblets/webapi/decorators.py", line 88, in _checklogin
>    return view_func(*args, **kwargs)
>  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-
> py2.6.egg/reviewboard/webapi/json.py", line 1263, in
> diff_line_comments
>    diffset__revision=diff_revision)
>  File "/usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/
> django/shortcuts/__init__.py", line 115, in get_object_or_404
>    raise Http404('No %s matches the given query.' %
> queryset.model._meta.object_name)
> Http404: No FileDiff matches the given query.
>
>
> Is anyone have experienced same issue?
>
> Please hale me... :)
>
> Thank you.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to