On Fri, Apr 22, 2011 at 3:23 AM, Christian Hammond <chip...@chipx86.com> wrote:
> Hi Jan,
>
> Extensions are the focus of post-1.6 development. There's a branch for this
> that can be used, but it's of course very experimental and not really
> supported yet.

I know that but I need it since I start using reviewboard and waiting
killing me every day.
Patient is not my strong point.

> I'm all for signals where they'd be useful. I think along with a "close", we
> should have a "reopen" signal.

I will add it too with pleasure.

> As for rbexternal, this isn't something I want to put into Review Board
> because it means we have to support it for a long time, even after putting
> extensions out there. When extensions support comes out, we'll have a
> proper, supported way of extending Review Board.
>
> Instead, I'd recommend doing that from your own settings_local.py.
> settings.py simply imports settings_local, which can then import your own
> stuff. That could add a Django app to the INSTALLED_APPS list, or just load
> code to connect to signals.

Of course - If clarity of architecture will be broken for something
like this - I understand. I didn't thought about it.
Idea with settings_local.py sounds nice :)

> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Thu, Apr 21, 2011 at 11:15 AM, Jan Koprowski <jan.koprow...@gmail.com>
> wrote:
>>
>> Hi,
>> I still need some kind of plugins ability inside ReviewBoard - right now
>> and I thought Isn't it a good idea to do this in 1.6 adding some more
>> signals and one additional external Django application which is empty.
>> Django itself are "plugable" thanks to "many applications inside one
>> project" model. Here is a idea:
>> Create one, empty application let say "rbexternal" and add it to
>> settings.py as last one.
>> Each fill will try to import some functions from unexisted model like:
>> try:
>>   from rbexternals import *
>> except ImportError:
>>   pass
>> and so on for models etc...
>> Idea is: to commit such empty Django application. This will allow to
>> create "rbexternals" module inside their Python environment and implement
>> methods .e.g signal's callbacks - which will be available from
>> reviewboard instance but without changing code inside repository.
>> What do You think? This doesn't need any big tests or something. This is
>> very simple idea based on well test Django behaviors.
>> I will be glad to do something like this in 1.6. Now I have settings.py
>> and signal collabacks in my private repo - it is not very bud but it is no
>> very good also.
>> Regards,
>> Jan
>>
>> --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~----------~----~----~----~------~----~------~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en



-- 
><> Jan Koprowski

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to