Please post a new topic for this.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, May 23, 2011 at 10:45 PM, Ashithraj Shetty <
asithraj.she...@gmail.com> wrote:

>  Hi,
>
>
>
> I would like to ask for couple of feature request for reviewboard.
>
>
>
> 1.       Right now we can close a review request even if it is not okayed
> by all the reviewers. Can you add in a feature where the review can be
> closed only if all the reviewers assigned to a review request have marked
> the request as SHIP IT! This way a coder cannot illegally close a review
> request if all the reviewers have not marked his request as SHIP IT!
>
> 2.       The SHIP IT! Column displays only the number of ship it counts.
> Can you modify it to show something like 1 out of 4. Where 1 is the number
> of SHIP IT count and 4 is the total number of reviewers assigned to this
> request and the people who still haven’t marked a request as ship it!
>
>
>
> Thanks and regards,
>
> -Ashith
>
>
>
>
>
>
>
> *From:* reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com]
> *On Behalf Of *Christian Hammond
> *Sent:* Tuesday, May 24, 2011 5:01 AM
> *To:* reviewboard@googlegroups.com
> *Subject:* Re: Red-line Boxes Around Words in diff Displays
>
>
>
> Hi Barry,
>
> It's most likely still in your server cache. We cache various stages of the
> diff generation process, and there are two (diff opcodes+attributes and
> rendered diff view) that can contain the definitions for those red boxes.
>
> I assume you're using memcached (if not, you should be! :). You can just
> flush the cache to remove those. Otherwise, any newly uploaded diffs should
> be rendered more correctly, providing the mapping is now correct and the web
> server was restarted.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>  On Mon, May 23, 2011 at 4:22 PM, Barry <
> barry.carr...@contractor.verio.net> wrote:
>
> Christian:
>
> You were right, of course; the files in question were .cfg files, which
> Pygments treats as INI type configuration files.  I haven't found a
> definition for the red-outline box, but my guess that it indicates something
> that the lexer doesn't recognize as valid in such a file.
>
> I have removed the '.cfg' entries in .../pygments/lexers/text.py and ran
> .../pygments/lexers/_mapping.py to remake the LEXERS dictionary.  However,
> when I view the diffs in question, the red outlines are still there.  Are
> the diffs highlghted when they are first uploaded into the database, or is
> there some additional step necessary apply the new mapping.
>
> Thanks for your help.
>
> Barry
>
>  --
>
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
>
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to