It looks like that we have RBTools-0.2rc1 version installed.
Is there a better way to check RB Tool version?


On May 23, 10:46 pm, "Ashithraj Shetty" <asithraj.she...@gmail.com>
wrote:
> Hi,
>
> I would like to ask for two feature requests,
>
> 1. Currently a developer can close his review request even though all the
> reviewers have not given a SHIP IT! Approval to his review request. Can you
> add a feature to block the developer from closing a review request till all
> the reviewers have marked the request as SHIP IT!. Would be cool if the
> reviewers also cannot close the review request till all the reviewers have
> marked a request as SHIP IT!
>
> 2. The SHIP IT! Column just shows the number of ship it counts. Can you also
> add a feature to show the count in the following way, 1 out of 4 where 1 is
> the SHIP IT! Count and 4 is the number of reviewers for the review request.
> This will help the auditors or the developers to know the status of review
> requests in a glance and take necessary measures based on the data.
>
> -Ashith
>
>
>
> -----Original Message-----
> From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On
>
> Behalf Of Christian Hammond
> Sent: Tuesday, May 24, 2011 11:11 AM
> To: reviewboard@googlegroups.com
> Subject: Re: How to handle binary files in a review?
>
> I recognize that error, but thought we had fixed that before. What
> version of RBTools are you running?
>
> Christian
>
> On Monday, May 23, 2011, mohak patel <mohakpate...@gmail.com> wrote:
> > Hi Christian,
>
> > We have been using Perfoce as the source control tool; review board
> > for the code review but review board throws error when developers post
> > the binary files.
>
> > We got this kind of error:
>
> > This tool looks at the given Pending-CL# & posts it for review.
> > [ Version: 20100217_1023/0.8]
> > Arguments: --p4vgui,--p4-client,user_Citrix_CDBnew,--p4-cl,358296,-d
>
> > post-review config: C:\<path> \Local Settings\Application Data
> > \.reviewboardrc
> > post-review cookie: C:\<path> \Application Data\.post-review-
> > cookies.txt
>
> >>>> "C:/Program Files/WinExePostReview/diff.exe" –urNp temp.spd
>
> > Traceback (most recent call last):
> >   File "post-review.py", line 2674, in <module>
> >   File "post-review.py", line 2638, in main
> >   File "post-review.py", line 1403, in diff
> >   File "post-review.py", line 1654, in _changenum_diff
> >   File "post-review.py", line 1737, in _do_diff
> > IndexError: list index out of range
>
> > Could you please help on this issue?
>
> > Thanks,
> > Mohak Patel
>
> > On May 16, 2:10 pm, Christian Hammond <chip...@chipx86.com> wrote:
> >> You shouldn't be getting an error. If the SCM is configured correctly,
> with
> >> the file type being set to binary, then the diff should just basically
> say
> >> "This is a binary file." The problem of course is that you can't actually
> >> review that file, but we're adding support for actual reviewable file
> >> attachments in 1.6, so that might help in some cases.
>
> >> What type of file is this? And what type of repository?
>
> >> Christian
>
> >> --
> >> Christian Hammond - chip...@chipx86.com
> >> Review Board -http://www.reviewboard.org
> >> VMware, Inc. -http://www.vmware.com
>
> >> On Mon, May 16, 2011 at 2:07 PM, Kunjal <kunjal.par...@gmail.com> wrote:
> >> > Hello,
>
> >> > We have RB-GIT integration and there are many times when the developer
> >> > adds binary files with the review.
> >> > When user tries to post review with binary file, we get error and
> >> > review can not be posted.
> >> > What is the best way to overcome this problem?
>
> >> > Thanks
> >> > Kunjal
>
> >> > --
> >> > Want to help the Review Board project? Donate today at
> >> >http://www.reviewboard.org/donate/
> >> > Happy user? Let us know athttp://www.reviewboard.org/users/
> >> > -~----------~----~----~----~------~----~------~--~---
> >> > To unsubscribe from this group, send email to
> >> > reviewboard+unsubscr...@googlegroups.com
> >> > For more options, visit this group at
> >> >http://groups.google.com/group/reviewboard?hl=en
>
> > --
> > Want to help the Review Board project? Donate today 
> > athttp://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~----------~----~----~----~------~----~------~--~---
> > To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group 
> > athttp://groups.google.com/group/reviewboard?hl=en
>
> --
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> --
> Want to help the Review Board project? Donate today 
> athttp://www.reviewboard.org/donate/
> Happy user? Let us know athttp://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group 
> athttp://groups.google.com/group/reviewboard?hl=en- Hide quoted text -
>
> - Show quoted text -

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to