Hi Chris, I missed some e-mails over the past month, so I'm working on getting caught up.
On Thu, Dec 1, 2011 at 4:44 AM, Chris Tooley <ch...@tooley.com> wrote: > First, let me say thank you for a great tool. We've been having a > lotof good success with ReviewBoard to date and with the exception of > afew small features we're hoping to be able to help with, it's > aresounding victory for our team. > The two features that have been frequently "pushed" to me are: > When replying to comments from multiple reviewers in a single > reviewrequest feedback to each reviewer gets "Publish"ed > separately,generating multiple emails. It would be great to have these > groupedtogether. This comes in a lot, but the reason we send multiple e-mails right now is that many companies are moving from an e-mail-based approach to code review, and we try to preserve a threaded environment. Each e-mail is carefully set up to simulate replies to parent e-mails. If you have one big e-mail that covers replies to a bunch of other reviews, you can't quite do that anymore. You also at that point need some UI around "Publish everything" vs. "Publish just this thing." You may not always want to publish everything. If you're working on a long review, but have a quick comment to make in a discussion, you'd need to be more careful. So rather than getting rid of a bunch of publish buttons, we'd just be adding one. That said, we can make a Publish All, but it'd still send multiple e-mails, unless we want to change our model. > Another option (and this is really a completely > separatefeature) would be to have a daily email of all the activity. > Sort oflike a mailing list can be subscribed to. > This would require that we add some sort of scheduled processing layer, which we don't have today. Since we do support mailing lists, and mailing lists support daily activity e-mails, I think that's the best place to do this. > We would love to be able to provide a categorization on > reviewcomments. This is by far the biggest "feature" we would like. > That waywe could set up rules to block the release of code which has > reviewcomments of a certain level. A dropdown on the review comment > orseries of checkboxes (though a dropdown allows for the ability > todefine custom levels in the admin interface) much like the > (openissue) checkbox would be perfect. > We discussed putting this in, and decided against making it a base feature. The reason being that we try to keep Review Board from having to deal with a lot of process and policy that may be specific to different companies. One company may want a drop-down of categories. Another may also want ratings, and severities. Another may want none. The plan is, once extensions are out, to make it possible to write an extension that adds this sort of capability. We could then potentially provide those as feature packs onto Review Board. No ETA on that, though, as we have to be careful about how we design it. > Incidentally... How do you see the "issues" that are open withoutgoing > into each review request and looking through each review foropen > issues? > You can't today. Though, I think a new sort of dashboard view that was a summary of what you need to address (comments replied to you, open issues, etc.) would be very handy. Christian > -- > > Chris Tooley > mobile: 615-525-8067 > Instant Messenger > MSN: ctoo...@ntrc.net > AIM: mrchristooley > Yahoo: mrchristooley > Google Talk: ctoo...@gmail.com > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en