Thanks David,

While separately we are not doing any pre or post commit review its only
the tool which post-review does that it. Yes the file is very large so what
could be done here, are their any enhancement we need to do in our review
board server or client to make this thing work. Please suggest.

On Sat, Mar 3, 2012 at 10:03 AM, David Trowbridge <trowb...@gmail.com>wrote:

> Are you doing pre- or post-commit reviews?
>
> post-review will try to send diffs for all non-binary files. There's no
> way to exclude individual files except for temporarily removing them from
> the changelist. If your .STEP files are actually large binaries, I'd
> suggest changing the filetype in perforce.
>
> If they're large text files which have big diffs, and you're doing
> post-commit reviews, it's not a great situation. Reviewers probably won't
> be able to deal with looking at very large diffs (and it's a big load on
> the server). You could falsely mark the file as binary, but that might
> interfere with line ending conversion (if you use that). Otherwise, it's
> possible that an improvement to post-review could be made to try to drop
> very large diffs instead of posting them.
>
> - David
>
> On Mar 2, 2012, at 6:45 PM, Nilesh Jaiswal <nileshj...@gmail.com> wrote:
>
> Hi,
>
> We are trying to check in the changes to perforce, but we see post-review
> got stuck, it happens for only one file with extention (.STEP) which is
> having headType as 'ctext', I would like to know if review board impose any
> restriction while posting the diff to review board for certain set of
> files. if yes then how could we solve this issue. if no what could be issue
> and where it got stuck.
>
> I can see reviewboard server has the file which has the *<some random
> number>.upload* (eg: tmpJq8GqG.upload ) file present in the /tmp/ which
> contain the files which is sent for review request.
>
> Please help on this its been urgent.
>
> Regards,
> Nilesh J
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to