I have a weird problem when uploading a diff of binary only changes. I have a 
diff with changes to two images, but somehow only one change is displayed in 
the diff viewer. It happens both when uploading a manually generated diff, as 
well as when using post-review. Is this a bug in reviewboard or am I doing 
something wrong?

I have a sample diff attached. The change to the first image is displayed, the 
second isn't.

diff --git a/res/drawable-hdpi/ic_launcher.png b/res/drawable-hdpi/ic_launcher.png
index 4585eedc233f593ce90ca0f244a35f8e2c023f17..fe3399ade44d6c18b79c67c6aa7bcccbcfbbca1f 100644
Binary files a/res/drawable-hdpi/ic_launcher.png and b/res/drawable-hdpi/ic_launcher.png differ
diff --git a/res/drawable-mdpi/ic_launcher.png b/res/drawable-mdpi/ic_launcher.png
index 8ce5efba8b9bef184b7d323a3d0b62b27169abc5..4b2c124753425e830ff95999e6f34b0ab9a67960 100644
Binary files a/res/drawable-mdpi/ic_launcher.png and b/res/drawable-mdpi/ic_launcher.png differ

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to