Hi,

I am not very comfortable with Python.

review-script is called from mercurial hook.

This is what I have found so far.


After fix for mercurial certificate warning messages
near error  File "/usr/local/lib/python2.6/dist-packages/rbtools/
clients/
mercurial.py", line 248, in _get_outgoing_changesets
    branch, rev = pair.strip().split('\n')
            try:
                branch, rev = pair.strip().split('\n')
            except ValueError:
                if 'warning: ' in pair:
                    continue

Got a new error message:
www-data@squeeze:~/hg/.hg$ python /var/www/hg/.hg/review-script
0477768532d98c2a8cb25d92b2a95ab1e14a73e6
>>> RBTools 0.4.1
>>> Home = /var/www
>>> HTTP GETting api/
>>> HTTP GETting https://127.0.0.1:443/reviewboard/api/info/
>>> Using the new web API
There don't seem to be any diffs!

Mercurial sees:
www-data@squeeze:~/hg/.hg$ hg log -v -r
0477768532d98c2a8cb25d92b2a95ab1e14a73e6

changeset:   28890:0477768532d9
branch:      t7702
parent:      28735:70bb78288793
parent:      28889:e169b5daf95b
user:        username
date:        Thu May 03 11:18:34 2012 +0800
files:       application...
description:
sync ...

when running post-review, I got:
www-data@squeeze:~/hg/.hg$ post-review --server=--server=https://
127.0.0.1/reviewboard --submit-as=username --username=user  --
password=password --publish --target-groups=USER_GROUPS --
summary='28890:0477768532d9' --description='long description' --
branch='t7702' --debug 0477768532d98c2a8cb25d92b2a95ab1e14a73e6
>>> RBTools 0.4.1
>>> Home = /var/www
>>> HTTP GETting api/
Traceback (most recent call last):
  File "/usr/local/bin/post-review", line 9, in <module>
    load_entry_point('RBTools==0.4.1', 'console_scripts', 'post-
review')()
  File "/usr/local/lib/python2.6/dist-packages/rbtools/postreview.py",
line 1222, in main
    if not server.check_api_version():
  File "/usr/local/lib/python2.6/dist-packages/rbtools/postreview.py",
line 226, in check_api_version
    root_resource = self.api_get('api/')
  File "/usr/local/lib/python2.6/dist-packages/rbtools/postreview.py",
line 669, in api_get
    return self.process_json(self.http_get(path))
  File "/usr/local/lib/python2.6/dist-packages/rbtools/postreview.py",
line 639, in http_get
    rsp = urllib2.urlopen(url).read()
  File "/usr/lib/python2.6/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.6/urllib2.py", line 391, in open
    response = self._open(req, data)
  File "/usr/lib/python2.6/urllib2.py", line 409, in _open
    '_open', req)
  File "/usr/lib/python2.6/urllib2.py", line 369, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.6/urllib2.py", line 1170, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.6/urllib2.py", line 1116, in do_open
    h = http_class(host, timeout=req.timeout) # will parse host:port
  File "/usr/lib/python2.6/httplib.py", line 661, in __init__
    self._set_hostport(host, port)
  File "/usr/lib/python2.6/httplib.py", line 686, in _set_hostport
    raise InvalidURL("nonnumeric port: '%s'" % host[i+1:])
httplib.InvalidURL: nonnumeric port: ''

On May 4, 5:27 am, Christian Hammond <chip...@gmail.com> wrote:
> Hi,
>
> Looks like some issue with the interpretation of the data coming from hg.
>
> How comfortable are you with Python? It'd be helpful to see what data it's 
> operating on.
>
> Christian
>
> On May 3, 2012, at 0:41, Juhani Tali <juhani.t...@estneti.com> wrote:
>
>
>
>
>
>
>
> > Hi,
>
> > I am a bit stuck with post-review errors.
> > What could be the problem?
>
> > review-script starts post-review with comments etc.
> > Version control is mercurial.
>
> > www-data@squeeze:~/hg/.hg$  python /var/www/hg/.hg/review-script
> > 0477768532d98c2a8cb25d92b2a95ab1e14a73e6
> >>>> RBTools 0.4.1
> >>>> Home = /var/www
> >>>> HTTP GETting api/
> >>>> HTTP GETtinghttps://127.0.0.1:443/reviewboard/api/info/
> >>>> Using the new web API
> > Traceback (most recent call last):
> >  File "/usr/local/bin/post-review", line 9, in <module>
> >    load_entry_point('RBTools==0.4.1', 'console_scripts', 'post-
> > review')()
> >  File "/usr/local/lib/python2.6/dist-packages/rbtools/postreview.py",
> > line 1248, in main
> >    diff, parent_diff = tool.diff(args)
> >  File "/usr/local/lib/python2.6/dist-packages/rbtools/clients/
> > mercurial.py", line 151, in diff
> >    return self._get_outgoing_diff(files)
> >  File "/usr/local/lib/python2.6/dist-packages/rbtools/clients/
> > mercurial.py", line 205, in _get_outgoing_diff
> >    self._get_outgoing_changesets(current_branch, remote)
> >  File "/usr/local/lib/python2.6/dist-packages/rbtools/clients/
> > mercurial.py", line 248, in _get_outgoing_changesets
> >    branch, rev = pair.strip().split('\n')
> > ValueError: too many values to unpack
>
> > Juhani Tali
>
> > --
> > Want to help the Review Board project? Donate today 
> > athttp://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~----------~----~----~----~------~----~------~--~---
> > To unsubscribe from this group, send email to 
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group 
> > athttp://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to