Hi Nilesh,

We run everything through GNU patch. That generally will handle the "\ No
newline at end of file".

What version of GNU patch is running on that server? What happens if you
try to apply that same patch on a developer machine?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, May 10, 2012 at 12:06 AM, Nilesh Jaiswal <nileshj...@gmail.com>wrote:

> Dear All,
>
> I have posted the queries on this but i haven't got any answer hence i am
> raising this queries again.
>
> After posting review request and then clicking on viewdiff link on RB
> server i get following error message for the files.
>
> The patch to
> '//sdm/DEV/V14_2_App/XSDGFDH/portals/sidadfds/resources/ApplicationManager.js'
> didn't apply cleanly. The temporary files have been left in
> '/tmp/reviewboard.pgHnuQ' for debugging purposes. `patch` returned:
> patching file /tmp/reviewboard.pgHnuQ/tmpVIuwIQ Hunk #2 FAILED at 931. 1
> out of 2 hunks FAILED -- saving rejects to file
> /tmp/reviewboard.pgHnuQ/tmpVIuwIQ-new.rej
>
> After looking into the /tmp/reviewboard.pgHnuQ/tmpVIuwIQ-new.rejor diff
> file in /tmp of RB server its says
>
> Pasting diff snippet which contains the following string (*\ No newline
> at end of file*) in ActionStatusEventHandlerThread.java.diff which has
> caused the diff error. why can we not handle such cases in viewdiff.py
> script. Do we have any patch for the same. I would appreciate if you could
> provide me solution that will solve 100's of such failure issues.
>
>
>
>
>
>                 private void log(Exception e) {
>
> @@ -86,4 +93,4 @@ public class ActionStatusEventHandlerThr
>
>                         return "ActionStatusEventHandlerThread";
>
>                 }
>
>
>
> -}
>
> +}
>
> *\ No newline at end of file*
>
> Regards,
> Nilesh J
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to