Christian, You are right in your observation that Diff's with large size are impossible to review, following are some of the reasons that can help you understand for the need of large diff sizes (as per my own experience):
1. There may be sample test files in the diff itself that usually increase the size. 2. Since the earlier versions didn't have much of a size limit, so the users just didn't care about the size limitation and during the upgrade, they are hit hard with the diff size limitation, change should be gradual. 3. Simple solution here is to divide large file checkin from the reviewable code but it's still difficult to communicate it over a large team size at once and enforce on a small time scale. thanks Ashish On Thu, May 17, 2012 at 12:53 AM, Christian Hammond <chip...@chipx86.com>wrote: > Hi Ashish, > > What's the size you're hitting with your diffs, and what's in them? Diffs > that are megabytes in size are generally impossible to review. > > I'll look at making the limit flexible, but I want to better understand > the problems people are hitting. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Wed, May 16, 2012 at 5:14 AM, Ashish Sharma > <ashiish.sha...@gmail.com>wrote: > >> Hi, >> >> With the release of Review Board (1.6.6), the diff file size is limited >> to 1MB only. >> >> Since my setup has a limit of 15MB with earlier version and with the >> latest update I am facing problems >> >> How can it be increased to say atleast to 10MB. >> >> thanks >> >> Ashish >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
