Are you saying it's not adding *anyone* if the poster is one of the default
reviewers? That's definitely not intended, and I'm seeing nothing in the
code that would cause that.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Jun 5, 2012 at 2:38 AM, Ashith <asithraj.she...@gmail.com> wrote:

> You were right, there was nothing wrong with the settings. The problem
> was I was setting myself as one of the default reviewers and trying to
> post a review request from my name. I tried posting review request as
> a different user and it added me and the other default reviewers to
> the reviewers section automatically.
>
> However, it is strange that review board does not add default
> reviewers to my review request because I am one of the default
> reviewer. Is this a bug or is it done on purpose?
>
> On May 29, 11:42 pm, Christian Hammond <chip...@gmail.com> wrote:
> > The only thing that looks wrong in the screenshots are the quotes.
> >
> > Christian
> >
> > On May 29, 2012, at 4:56, Ashith <asithraj.she...@gmail.com> wrote:
> >
> >
> >
> >
> >
> >
> >
> > > I am not able to attach a screenshot to this post. I will email you
> > > the screen shot on your ID.
> >
> > > We use postreview plugin for TortoiseHG to create review request and
> > > post it. We use mercurial as our SCM.
> >
> > > -Ashith
> >
> > > On May 29, 12:46 pm, Christian Hammond <chip...@chipx86.com> wrote:
> > >> Hi Ashith,
> >
> > >> You definitely don't want double quotes in the regex. The .* alone
> should
> > >> work.
> >
> > >> I haven't seen this not work before. Can you give me an explicit
> > >> step-by-step of how you're creating the review request, and at one
> points
> > >> you check it?
> >
> > >> Would you also mind screenshotting the configuration page for this?
> >
> > >> Christian
> >
> > >> --
> > >> Christian Hammond - chip...@chipx86.com
> > >> Review Board -http://www.reviewboard.org
> > >> VMware, Inc. -http://www.vmware.com
> >
> > >> On Tue, May 29, 2012 at 12:17 AM, Ashith <asithraj.she...@gmail.com>
> wrote:
> > >>> I have the following settings done for Default Reviewers,
> >
> > >>> Name: ABC
> > >>> File Regular Expression: ".*" (I have used double quotes in the
> regexp
> > >>> part. I have also tried without double quotes as well)
> > >>> Default Group: Blank
> > >>> Default People: ABC, XYZ
> > >>> Repositories: Blank
> >
> > >>> Now, I tried posting a review request and go on to check the review
> > >>> request in Review Board I find that the default reviewers are not
> > >>> automatically added to the reviewers list.
> >
> > >>> Can you tell me what is going wrong?
> >
> > >>> --
> > >>> Want to help the Review Board project? Donate today at
> > >>>http://www.reviewboard.org/donate/
> > >>> Happy user? Let us know athttp://www.reviewboard.org/users/
> > >>> -~----------~----~----~----~------~----~------~--~---
> > >>> To unsubscribe from this group, send email to
> > >>> reviewboard+unsubscr...@googlegroups.com
> > >>> For more options, visit this group at
> > >>>http://groups.google.com/group/reviewboard?hl=en
> >
> > > --
> > > Want to help the Review Board project? Donate today athttp://
> www.reviewboard.org/donate/
> > > Happy user? Let us know athttp://www.reviewboard.org/users/
> > > -~----------~----~----~----~------~----~------~--~---
> > > To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> > > For more options, visit this group athttp://
> groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to