the review number is the same. In an old revision I see the comments.
I thought that when you go to let's say r3 you would see the comments on
that diff but if you select show diff betweet r1 and r3 you would see the
comments done on r1.
I thought reviewboard does that... maybe I'm remembering Mondrian.
And if you see
http://demo.reviewboard.org/r/54/diff/2-3/#index_header you will see in the
last file (diff_update.txt) a comment made in
On Thursday, July 5, 2012 3:54:25 PM UTC-3, Christian Hammond wrote:
> Hi ZeoS,
> We never show the previous diff's comments on the new diff, as line
> numbers and code change and we have no way of knowing what to bring over
> and what not to. The comments are always on the review request page in
> previous reviews, and you can also see them when selecting the older
> revision in the diff viewer.
> If you view the older revision, do you see the comments there?
> Is the review request ID number the same between the two?
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
> On Thu, Jul 5, 2012 at 10:18 AM, ZeoS <fot...@gmail.com> wrote:
>> Hi all,
>> I'm doing a POC with ReviewBoard, seeing if it's good for my current
>> project. I used sometime ago with SVN and worked great.
>> Now I'm using it with Mercurial, the problem I'm facing is that when I
>> post a new diff I don't see the comments for the previous one.
>> The structure: I basically pull from a repo R, do changes in a branch (B)
>> that I end up pushing to R. after that I run
>> hg postreview B
>> Somebody looks at the code, makes some comments, I change the code on B,
>> push it again to R and run
>> hg postreview -e ### B
>> When I go to reviewboard I see the diff with the previous change but I
>> can't see the comments.
>> I also tried with
>> hg postreview -e### -p parent_of_both B
>> which is more complete but I still can't see the comments.
>> Maybe I forgot to enable something?
>> Thanks for your help!
>> Want to help the Review Board project? Donate today at
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> To unsubscribe from this group, send email to
>> For more options, visit this group at
Want to help the Review Board project? Donate today at
Happy user? Let us know at http://www.reviewboard.org/users/
To unsubscribe from this group, send email to
For more options, visit this group at