Hi Christian,

This isn't ready (can't stress that enough) but I posted a review at
http://reviews.reviewboard.org/r/3217/ because I'm stuck on a few technical
details.  Can you give me some pointers so I can move forward with this
change?

-Steve

On Thu, Jul 12, 2012 at 10:06 PM, Christian Hammond <chip...@chipx86.com>wrote:

> Hi Steve,
>
> We don't accept pull requests, since we require that everything goes
> through our own Review Board server. That's at
> http://reviews.reviewboard.org/. We have a Getting Started guide up at
> http://www.reviewboard.org/docs/codebase/dev/getting-started/ that may be
> helpful. There's also more information up at
> http://www.reviewboard.org/docs/codebase/dev/
>
> Let me know if you have any questions.
>
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Thu, Jul 12, 2012 at 7:22 PM, Stephen Holsapple <shols...@gmail.com>wrote:
>
>> Okay, I'll see what I can do.  Thanks for the suggestion, I'll check that
>> out.  I've already started looking around in the webapi/ at some of the
>> other resources.  I'll have a patch sometime next week hopefully.
>>
>> Is there a crash-course for RB development I should read for
>> patching/reviewing?  Or when I have a patch on my github should I just pull
>> request?
>>
>> -Steve
>>
>>
>> On Thu, Jul 12, 2012 at 6:44 PM, Christian Hammond 
>> <chip...@chipx86.com>wrote:
>>
>>> Adding proper API for group creation/modification would be the best
>>> option, and one I'd gladly accept. It wouldn't be a lot of work to add that
>>> support. Probably want to look at the code in webapi/resources.py that
>>> manages repositories or something to get a feel for how it'd work. (Though,
>>> repositories have validation complexity you wouldn't care about.)
>>>
>>>
>>> Christian
>>>
>>> --
>>> Christian Hammond - chip...@chipx86.com
>>> Review Board - http://www.reviewboard.org
>>> VMware, Inc. - http://www.vmware.com
>>>
>>>
>>> On Thu, Jul 12, 2012 at 5:25 PM, sholsapp <shols...@gmail.com> wrote:
>>>
>>>> Ah, you're right, the groups were displayed because they were cached.
>>>>
>>>> We're deleting/creating the groups daily because we're trying to
>>>> synchronize our LDAP groups with RB groups and 1) RB doesn't support this
>>>> natively and 2) the webapi doesn't support group create/modify.  The only
>>>> option we had was to scrape it.
>>>>
>>>> Maybe I can patch the webapi... but I haven't started looking into this
>>>> yet.  Is this possible?
>>>>
>>>>
>>>> -Steve
>>>>
>>>>
>>>>  --
>>>> Want to help the Review Board project? Donate today at
>>>> http://www.reviewboard.org/donate/
>>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>>> -~----------~----~----~----~------~----~------~--~---
>>>> To unsubscribe from this group, send email to
>>>> reviewboard+unsubscr...@googlegroups.com
>>>> For more options, visit this group at
>>>> http://groups.google.com/group/reviewboard?hl=en
>>>>
>>>
>>>  --
>>> Want to help the Review Board project? Donate today at
>>> http://www.reviewboard.org/donate/
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> -~----------~----~----~----~------~----~------~--~---
>>> To unsubscribe from this group, send email to
>>> reviewboard+unsubscr...@googlegroups.com
>>> For more options, visit this group at
>>> http://groups.google.com/group/reviewboard?hl=en
>>>
>>
>>
>>
>>  --
>> -Steve
>>
>>  --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~----------~----~----~----~------~----~------~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>>
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>



-- 
-Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to