Christian, comments? :-)

thanks a lot, 
Hans

On Thursday, July 19, 2012 5:09:06 PM UTC+8, Hans Shi wrote:
>
> thanks Christian for the answers. are you saying each svn command (svn 
> info, svn diff, etc) set different permission access? 
>
> thanks a lot,
> Hans
>
> On Wednesday, July 18, 2012 5:51:55 PM UTC+8, Christian Hammond wrote:
>>
>> post-review just runs 'svn info' and 'svn diff' and other commands from 
>> the repository. So it's not really a matter of configuring post-review. 
>> It's a matter of making sure your SVN checkout can run those commands 
>> manually, without passing credentials on the command line. There's no 
>> mechanism to pass SVN credentials through post-review.
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chip...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>> On Wed, Jul 18, 2012 at 1:56 AM, Hans Shi <hansn...@gmail.com> wrote:
>>
>>> i guess this is a general case for svn auth, anybody encounter this too?
>>>
>>>
>>>
>>> On Wednesday, July 18, 2012 4:51:08 PM UTC+8, Hans Shi wrote:
>>>>
>>>> then i change svn server with anonymous access enabled... the 
>>>> post-review successfully conducted and reviewboard request is generated as 
>>>> well. 
>>>>
>>>> our svn uses LDAP auth with Windows Domain users, so can i put auth 
>>>> infor as parameters in post-review command? if yes, how? if not, any 
>>>> alternative approaches to resolve this? 
>>>>
>>>> thanks a lot, 
>>>> Hans
>>>>
>>>>
>>>> On Wednesday, July 18, 2012 4:39:09 PM UTC+8, Hans Shi wrote:
>>>>>
>>>>> hi Christian, 
>>>>>
>>>>> No, it doesn't related by client cookie. Previous testing i made on 
>>>>> dev svn server, to avoid interrupt dev's work, I setup another SVN server 
>>>>> which is exact the same configuration as dev's real one. The issue still 
>>>>> happen with the same phenomenon. 
>>>>>
>>>>> i revised the py code as below without indicate the*--repository-url=XXX
>>>>> *: 
>>>>>
>>>>> log_cmd = 'D:/Python25/Scripts/post-**review.exe --debug 
>>>>> --revision-range=19:20 --publish --username=ghost --password=ghost 
>>>>> --submit-as=hans.shi --summary="hans.shi code submit at version #20" '
>>>>>  log('post-review commmand: ' + log_cmd)
>>>>>
>>>>> fh=os.popen(log_cmd, 'r')
>>>>>  for val in fh.readlines():
>>>>> log('value:' + val.rstrip())
>>>>>  log('post-review executed successfully!!! ')
>>>>>
>>>>> the log output as below which mean the post-review command is executed 
>>>>> successfully: 
>>>>>
>>>>> post-review commmand: D:/Python25/Scripts/post-**review.exe --debug 
>>>>> --revision-range=19:20 --publish --username=ghost --password=ghost 
>>>>> --submit-as=hans.shi --summary="hans.shi code submit at version #20" 
>>>>> value:>>> RBTools 0.4.1
>>>>> value:>>> Home =
>>>>> value:The current directory does not contain a checkout from a
>>>>> value:supported source code repository.
>>>>>
>>>>> so i'm doubting the svn auth in post-review command.... more to come...
>>>>>
>>>>>
>>>>> On Wednesday, July 4, 2012 3:39:16 PM UTC+8, Christian Hammond wrote:
>>>>>>
>>>>>> Just speculating, but perhaps it's not finding your cookie file when 
>>>>>> run through the hook, and is therefore prompting for input.
>>>>>>
>>>>>> Christian
>>>>>>
>>>>>> -- 
>>>>>> Christian Hammond - chip...@chipx86.com
>>>>>> Review Board - http://www.reviewboard.org
>>>>>> VMware, Inc. - http://www.vmware.com
>>>>>>
>>>>>>
>>>>>> On Wed, Jul 4, 2012 at 12:31 AM, Hans Shi <hansn...@gmail.com> wrote:
>>>>>>
>>>>>>> anybody else met this similar issue?
>>>>>>>
>>>>>>>
>>>>>>> On Tuesday, July 3, 2012 3:57:53 PM UTC+8, Hans Shi wrote:
>>>>>>>>
>>>>>>>> Hi Christian, 
>>>>>>>>
>>>>>>>> thanks for the reply. there is no firewall between svn server and 
>>>>>>>> reviewboard server, as you can see my login user afra.liu can execute 
>>>>>>>> post-review command and generate reviewboard request successfully. 
>>>>>>>>
>>>>>>>> any other clues? 
>>>>>>>>
>>>>>>>> thanks again, 
>>>>>>>> Hans
>>>>>>>>
>>>>>>>> On Tuesday, July 3, 2012 3:04:51 PM UTC+8, Christian Hammond wrote:
>>>>>>>>>
>>>>>>>>> Hi Hans,
>>>>>>>>>
>>>>>>>>> Are you behind a firewall? If so, the proper settings may not be 
>>>>>>>>> provided in the context of whatever is running the script.
>>>>>>>>>
>>>>>>>>> Christian
>>>>>>>>>
>>>>>>>>> -- 
>>>>>>>>> Christian Hammond - chip...@chipx86.com
>>>>>>>>> Review Board - http://www.reviewboard.org
>>>>>>>>> VMware, Inc. - http://www.vmware.com
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mon, Jul 2, 2012 at 11:17 PM, Hans Shi <hansn...@gmail.com>wrote:
>>>>>>>>>
>>>>>>>>>> Hi there, 
>>>>>>>>>>
>>>>>>>>>> May i have a question for ReviewBoard post-review invokved by 
>>>>>>>>>> svn's post-commit.bat? 
>>>>>>>>>>
>>>>>>>>>> when i use python code to auto execute post-review command when 
>>>>>>>>>> developer checks in a code, the svn window stucks there with no 
>>>>>>>>>> response, 
>>>>>>>>>> but eventually will prompt timeout error. 
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> <https://lh4.googleusercontent.com/-19NDSZi03W4/T_KMdL1xcTI/AAAAAAAAFzI/ZnZBOu70Vtc/s1600/check-in+stuck.png>
>>>>>>>>>>
>>>>>>>>>> From the svn server, post-review command is stuck there as well, 
>>>>>>>>>> interestingly when i get the post-review command, and execute it in 
>>>>>>>>>> dos 
>>>>>>>>>> window, it works and can generate review request successfully. (the 
>>>>>>>>>> difference is different executors, one is login user, one is SYSTEM 
>>>>>>>>>> user)
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> <https://lh6.googleusercontent.com/-ZuAM5fTuquw/T_KOWsqNqVI/AAAAAAAAFzU/g9XnY9P3RE8/s1600/post-review+backend.png>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> who can help me out? i've struggled in reviewboard integration 
>>>>>>>>>> into svn for a few weeks, SOS!!
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> thank you very much in advance, 
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Hans
>>>>>>>>>>
>>>>>>>>>>  -- 
>>>>>>>>>> Want to help the Review Board project? Donate today at 
>>>>>>>>>> http://www.reviewboard.org/**don**ate/<http://www.reviewboard.org/donate/>
>>>>>>>>>> Happy user? Let us know at 
>>>>>>>>>> http://www.reviewboard.org/**use**rs/<http://www.reviewboard.org/users/>
>>>>>>>>>> -~----------~----~----~----~--****----~----~------~--~---
>>>>>>>>>> To unsubscribe from this group, send email to 
>>>>>>>>>> reviewboard+unsubscribe@**google**groups.com<reviewboard%2bunsubscr...@googlegroups.com>
>>>>>>>>>> For more options, visit this group at http://groups.google.com/**
>>>>>>>>>> group**/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>  -- 
>>>>>>> Want to help the Review Board project? Donate today at 
>>>>>>> http://www.reviewboard.org/**donate/<http://www.reviewboard.org/donate/>
>>>>>>> Happy user? Let us know at 
>>>>>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/>
>>>>>>> -~----------~----~----~----~--**----~----~------~--~---
>>>>>>> To unsubscribe from this group, send email to 
>>>>>>> reviewboard+unsubscribe@**googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
>>>>>>> For more options, visit this group at http://groups.google.com/**
>>>>>>> group/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en>
>>>>>>>
>>>>>>
>>>>>>  -- 
>>> Want to help the Review Board project? Donate today at 
>>> http://www.reviewboard.org/donate/
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> -~----------~----~----~----~------~----~------~--~---
>>> To unsubscribe from this group, send email to 
>>> reviewboard+unsubscr...@googlegroups.com
>>> For more options, visit this group at 
>>> http://groups.google.com/group/reviewboard?hl=en
>>>
>>
>>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to