The user finally got back to me.
That was exactly the issue: user B ran post-review on user A shell, so user A was using user B sessionid cookie.


It's a bit of a fringe case but maybe there could be a config option that requires (or warns) the user if the system username doesn't match the Review Board name. It could then prompt whether we want to create or override the existing cookie, or use the new sessionid for that operation only.
But then again, it is a fringe case.

Thanks,
Dado


On Mon, 16 Jul 2012 22:57:46 -0700, Christian Hammond <chip...@chipx86.com> wrote:
Hi Dado,

That was most likely the issue. Let me know if removing that doesn't
solve the problem.

Christian

--
Christian Hammond - chip...@chipx86.com [1]
 Review Board - http://www.reviewboard.org [2]
VMware, Inc. - http://www.vmware.com [3]

On Mon, Jul 16, 2012 at 6:56 PM, Dado Feigenblatt  wrote:
Oh, could user A's ~/.post-review-cookies.txt have user B session ID?
 User A is gone for the day.
 I'll post back tomorrow after I have user A authenticating again.

 Thanks,
 Dado

 On Mon, 16 Jul 2012 18:07:19 -0700, Dado Feigenblatt  wrote:
  Hi,

 I have a user A who all of his review requests end up being owned by
 another user B.
 I tried it myself in a clean environment.
 I became user A and posted a review with no extra arguments and it
 also ended up being owned by user B.

 I stepped through post-review up to when it calls
     rsp = self.api_post(review_request_href, data)
 and successfully creates a new request.
 At that point I checked the admin interface and the request was
 already owned by user B.

 For completeness sake, the arguments to the api post are

   review_request_href = http://rboard02v/api/review-requests/ [6]
   data = {'changenum': '714435', 'repository': 'perforce04:1666'}

 I have no idea where user B is coming from.
 The users say at one point user A was having problems posting a
 review, then user B logged in and posted the review as himself.
 They can't remember exactly what they did, but apparently this is
 when the problems begun.
 Whatever they did, I don't understand how that could "break" things
 for user A permanently.

 Using RBTools 0.4.1

 Any help would be greatly appreciated.

 Thanks,
 Dado

 --
 Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/ [7]
 Happy user? Let us know at http://www.reviewboard.org/users/ [8]
 -~----------~----~----~----~------~----~------~--~---
 To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com [9]
 For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en [10]

 --
 Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/ [11]
 Happy user? Let us know at http://www.reviewboard.org/users/ [12]
 -~----------~----~----~----~------~----~------~--~---
 To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en [13]

Links:
------
[1] mailto:chip...@chipx86.com
[2] http://www.reviewboard.org
[3] http://www.vmware.com
[4] mailto:d...@dado.org
[5] mailto:d...@dado.org
[6] http://rboard02v/api/review-requests/
[7] http://www.reviewboard.org/donate/
[8] http://www.reviewboard.org/users/
[9] mailto:reviewboard%2bunsubscr...@googlegroups.com
[10] http://groups.google.com/group/reviewboard?hl=en
[11] http://www.reviewboard.org/donate/
[12] http://www.reviewboard.org/users/
[13] http://groups.google.com/group/reviewboard?hl=en

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to