Hi Tarun,

Would it possible if you can share the script to convert clearcase diff to 
unified diff, that can be parsed by RB.
Also will the genrated format be able to upload via WEB GUI RB.

Thanks
Peer

On Wednesday, August 6, 2008 10:38:05 AM UTC+5:30, Tarun wrote:
>
> I hadn't used post review before.....I used to post new reviews the 
> hard way.....by hand! 
>
> I guess I will start using post review now and see how i can make a 
> diff for the ClearCase file. 
>
> About the ClearCase SCMTool , I have a custom tool that I wrote up. It 
> is similar to the CVS SCMTool; since I generate my diffs in a certain 
> format my Clearcase SCMTool is able to parse that format and use it as 
> a normal diff file. 
>
> -Tarun 
>
> Christian Hammond wrote: 
> > That's one of the reasons post-review exists. If you look at the 
> Perforce 
> > code, you'll see we build our own diff. In your case, you should 
> probably 
> > use the serialized diff and go over and process it to turn it into a 
> unified 
> > diff, or just generate your own completely. 
> > 
> > As for the repository type, I don't understand fully. We don't have a 
> > ClearCase SCMTool, so what are you using? Something custom? 
> > 
> > Christian 
> > 
> > -- 
> > Christian Hammond - chi...@chipx86.com <javascript:> 
> > VMware, Inc. 
> > 
> > 
> > On Tue, Aug 5, 2008 at 4:56 AM, Tarun <taru...@gmail.com <javascript:>> 
> wrote: 
> > 
> > > 
> > > 
> > > > What do you use for the repository type on Review Board? 
> > > I didnt quite understand this question, I use a clearcase repository 
> > > on my Review Board setup. 
> > > 
> > > 
> > > I am working on the post review aspect to see how I can implement it 
> > > for Clearcase. 
> > > 
> > > About the clearcase diff issue. Clearcase gives a command to present a 
> > > diff in a format where the predecessor file and the current file can 
> > > be shown in the diff file. This is called the serial format, but the 
> > > problem with this format is that it cannot be identified by the patch 
> > > command. For example, I have the diff over here for a file named avm- 
> > > mib-nointervention.tcl 
> > > 
> > > Diff: Serial format 
> > > 
> > > 
> > > ******************************** 
> > > <<< file 1: /vobs/tetware/systems/avm-mib-nointervention.tcl@@/main/ 
> > > tware_avan_r3_br/test_infra_br/0 
> > > >>> file 2: avm-mib-nointervention.tcl 
> > > ******************************** 
> > > -----[1 changed to 1-2]----- 
> > > < #!/usr/bin/expect 
> > > --- 
> > > > #!/usr/bin/tcl 
> > > > package require Expect 
> > > -----[775 changed to 776]----- 
> > > < source $env(TET_ROOT)/lib/expect/expect.tcm.dat 
> > > --- 
> > > > source $env(TET_ROOT)/lib/tcl/tcl.tcm.dat 
> > > 
> > > 
> > > 
> > > Now file 1 is the predecessor file(previous revision) and file 2 is 
> > > the current file(working copy) . To mention changed lines, the diff 
> > > presents it verbosely 
> > > 
> > > -----[775 changed to 776]----- 
> > > 
> > > it is this line that creates a conflict. 
> > > 
> > > 
> > > Now the other clearcase diff format (the unified diff format option) 
> > > presents the output in the following format 
> > > 
> > > 1c1,2 
> > > < #!/usr/bin/expect 
> > > --- 
> > > > #!/usr/bin/tcl 
> > > > package require Expect 
> > > 775c776 
> > > < source $env(TET_ROOT)/lib/expect/expect.tcm.dat 
> > > --- 
> > > > source $env(TET_ROOT)/lib/tcl/tcl.tcm.dat 
> > > 
> > > The diff in this format can be understood by the patch command, but 
> > > with this option I cannot get the predecessor and the current file to 
> > > be mentioned in the diff file. 
> > > 
> > > Thats why I had to write a script to meet my needs. 
> > > 
> > > 
> > > 
> > > -Tarun 
> > > 
> > > Christian Hammond wrote: 
> > > > What do you use for the repository type on Review Board? 
> > > > 
> > > > It would be good to integrate a lot of this into post-review. 
> post-review 
> > > > already does stuff for other repository types to mold the diffs into 
> > > having 
> > > > the required data we need. I don't know if I fully understand the 
> diff 
> > > > issue, but post-review could generate the multiple diffs and 
> concatenate 
> > > > them into a single diff automatically. 
> > > > 
> > > > Christian 
> > > > 
> > > > -- 
> > > > Christian Hammond - chi...@chipx86.com <javascript:> 
> > > > VMware, Inc. 
> > > > 
> > > > 
> > > > On Mon, Aug 4, 2008 at 11:50 PM, Tarun <taru...@gmail.com<javascript:>> 
> wrote: 
> > > > 
> > > > > 
> > > > > Hi Akshay, 
> > > > > 
> > > > > I have reviewboard setup with clearcase(i would not call it a 
> proper 
> > > > > integration though....i shall explain it). This is on RHEL4. 
> > > > > 
> > > > > My setup has an intermediary step. This involves a user to run a 
> > > > > script that generates diff for multiple files present in the 
> clearcase 
> > > > > repository in the unified diff format. Another reason I have the 
> users 
> > > > > run this script because i can then get the revision number for a 
> > > > > particular file. (If you know of a way to generate multiple diffs 
> in a 
> > > > > single file....please let me know. I do not use the clearcase 
> > > > > "cleartool diff serial format" command to generate the diffs as 
> they 
> > > > > are not in the diff format that can be recognised by the patch 
> command 
> > > > > and the clearcase "cleartool diff diff format" command does not 
> show 
> > > > > the revision number though it is the format understood by the 
> patch 
> > > > > command.) Because of this I make use of a python script that 
> resolves 
> > > > > these issues. 
> > > > > 
> > > > > Once I have the diffs generated, the user then uploads this to 
> > > > > reviewboard which is understood by my parser and results the 
> output in 
> > > > > the normal reviewboard view. 
> > > > > 
> > > > > This is my process of how I integrated clearcase with review 
> board. 
> > > > > 
> > > > > 
> > > > > -Tarun 
> > > > > 
> > > > > 
> > > > > akshay wrote: 
> > > > > > Thanx Christian for your reply. 
> > > > > > 
> > > > > > Perhaps I can try to provide a patch :) 
> > > > > > 
> > > > > > Will update you once I get something working. 
> > > > > > 
> > > > > > Akshay. 
> > > > > > 
> > > > > > On Aug 2, 11:09´┐Żam, "Christian Hammond" <chip...@chipx86.com> 
> wrote: 
> > > > > > > Hi. 
> > > > > > > 
> > > > > > > Review Board doesn't yet support Clearcase. We'll welcome a 
> patch 
> > > for 
> > > > > it but 
> > > > > > > so far nobody's given us a working patch for Clearcase 
> > > repositories. 
> > > > > > > 
> > > > > > > Christian 
> > > > > > > 
> > > > > > > -- 
> > > > > > > Christian Hammond - chip...@chipx86.com 
> > > > > > > VMware, Inc. 
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Fri, Aug 1, 2008 at 5:05 AM, akshay <
> akshay.ran...@gmail.com> 
> > > > > wrote: 
> > > > > > > 
> > > > > > > > Hi guys, 
> > > > > > > 
> > > > > > > > I am trying to setup Review Board on my Solaris 10 x86 
> machine 
> > > with 
> > > > > > > > clearcase. 
> > > > > > > 
> > > > > > > > But, I could not find any clearcase repository support 
> neither 
> > > > > Solaris 
> > > > > > > > was mentioned. 
> > > > > > > 
> > > > > > > > Could any of you guide me if clearcase is being used as the 
> > > source 
> > > > > > > > reporsitory somewhere ? 
> > > > > > > 
> > > > > > > > Thanx, 
> > > > > > > > Akshay.- Hide quoted text - 
> > > > > > > 
> > > > > > > - Show quoted text - 
> > > > > > 
> > > > > 
> > > > 
> > >

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to