Wow that's super nice! I'm looking forward to it!

Btw, any sense of time estimation of 1.7.0? :P

Pine

On Wednesday, October 10, 2012 10:52:03 AM UTC+8, Christian Hammond wrote:
>
> Okay, in that case you do for now.
>
> The good news is that this use case is something we're going to be 
> focusing on going forward. We have work in progress for uploading non-code 
> files along with a diff, and are building review UI functionality for a 
> couple different file types. Parts of this will land in 1.7.0, and other 
> parts in 1.7.x. So a solution *is* coming :)
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com <javascript:>
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Tue, Oct 9, 2012 at 7:39 PM, Pine <pi...@happylatte.com 
> <javascript:>>wrote:
>
>> Hi Christian,
>>
>> Ya that kind of works. But the initial idea is, we'd like to automate 
>> this workflow. Since we're trying to do the similar thing as code review in 
>> design team, which is reviewing the source files, we want to try to make 
>> the workflow similar to dev team, e.g. auto posting review request when 
>> source files are committed.
>>
>> So seems I have to work on the meta file now.
>>
>> Pine
>>
>>
>> On Wednesday, October 10, 2012 4:21:37 AM UTC+8, Christian Hammond wrote:
>>
>>> Hi Pine,
>>>
>>> If you just want some images up for review, then don't bother with a 
>>> diff. Just create a new review request that isn't tied to a repository, and 
>>> drag-and-drop them into the review request (assuming a modern enough 
>>> browser), or click Upload Screenshot.
>>>
>>> Reviewers will be able to make comments right on the image.
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chi...@chipx86.com
>>>
>>> Review Board - http://www.reviewboard.org
>>> VMware, Inc. - http://www.vmware.com
>>>
>>>
>>> On Tue, Oct 9, 2012 at 5:10 AM, Pine Du <mep...@gmail.com> wrote:
>>>
>>>>  Hi there,
>>>>
>>>> We're trying to install review board for graphic artists as well, as 
>>>> the tool to post comments on each other's source files, and we found that 
>>>> there won't be any diff for non-textual file changes. But we also saw that 
>>>> if we set: svn diff --force there will be some diff generated. We just 
>>>> cannot find where to set this in hook of review board.
>>>>
>>>> So I wonder, is there any way to set it in the hook?
>>>>
>>>> If not I think to generate a meta file for each binary file is the best 
>>>> way to do this.
>>>>
>>>> Thanks,
>>>> Pine
>>>>
>>>> -- 
>>>> Want to help the Review Board project? Donate today at 
>>>> http://www.reviewboard.org/**donate/<http://www.reviewboard.org/donate/>
>>>> Happy user? Let us know at 
>>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/>
>>>> -~----------~----~----~----~--**----~----~------~--~---
>>>> To unsubscribe from this group, send email to reviewboard...@**
>>>> googlegroups.com
>>>>
>>>> For more options, visit this group at http://groups.google.com/**
>>>> group/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en>
>>>>
>>>
>>>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to