Thank Chris, But ideally if there is no diff as there is unmodified files in the changelist, why post-review bailing out and restricting user to raise a review request successfully.
Regards, Nilesh On Tue, Oct 16, 2012 at 12:42 PM, Christian Hammond <chip...@chipx86.com>wrote: > You can keep it in one place and just make a symlink to the other (though > it doesn't really make sense to have it in more than one place). The whole > thing is that Apache has /usr/bin in its path, and not /usr/local/bin. > > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Tue, Oct 16, 2012 at 12:02 AM, Nilesh Jaiswal <nileshj...@gmail.com>wrote: > >> Hi Chris, >> >> Since you asked me to move p4 to /usr/bin, what if i keep this in >> /usr/local/bin/ and /usr/bin? >> >> Regards, >> Nilesh >> >> On Mon, Aug 6, 2012 at 2:50 PM, Christian Hammond <chip...@chipx86.com>wrote: >> >>> Glad it works! >>> >>> >>> Christian >>> >>> -- >>> Christian Hammond - chip...@chipx86.com >>> Review Board - http://www.reviewboard.org >>> VMware, Inc. - http://www.vmware.com >>> >>> >>> On Mon, Aug 6, 2012 at 1:04 AM, Nilesh Jaiswal <nileshj...@gmail.com>wrote: >>> >>>> Hello Mr Life Saver !! >>>> >>>> You made my work so easy !! you are fantastic !! >>>> >>>> Whole of MSC Software will be proud of you !! >>>> >>>> Thank you so much. >>>> >>>> >>>> On Mon, Aug 6, 2012 at 1:28 PM, Christian Hammond >>>> <chip...@chipx86.com>wrote: >>>> >>>>> Move it to /usr/bin so Apache can see it. >>>>> >>>>> >>>>> Christian >>>>> >>>>> -- >>>>> Christian Hammond - chip...@chipx86.com >>>>> Review Board - http://www.reviewboard.org >>>>> VMware, Inc. - http://www.vmware.com >>>>> >>>>> >>>>> On Mon, Aug 6, 2012 at 12:51 AM, Nilesh Jaiswal >>>>> <nileshj...@gmail.com>wrote: >>>>> >>>>>> I am having p4 installed at /usr/local/bin/p4 >>>>>> >>>>>> What should i do.? >>>>>> >>>>>> >>>>>> On Mon, Aug 6, 2012 at 1:19 PM, Christian Hammond < >>>>>> chip...@chipx86.com> wrote: >>>>>> >>>>>>> You don't have p4 installed in a path that Apache can access. Make >>>>>>> sure it's installed in /usr/bin. >>>>>>> >>>>>>> >>>>>>> Christian >>>>>>> >>>>>>> -- >>>>>>> Christian Hammond - chip...@chipx86.com >>>>>>> Review Board - http://www.reviewboard.org >>>>>>> VMware, Inc. - http://www.vmware.com >>>>>>> >>>>>>> >>>>>>> On Mon, Aug 6, 2012 at 12:40 AM, Nilesh Jaiswal < >>>>>>> nileshj...@gmail.com> wrote: >>>>>>> >>>>>>>> here you go: >>>>>>>> >>>>>>>> >>>>>>>> 2012-08-06 00:00:57,711 - DEBUG - DiffParser.parse: Finished >>>>>>>> parsing diff. >>>>>>>> 2012-08-06 00:00:57,800 - ERROR - Error uploading new diff: [Errno >>>>>>>> 2] No such file or directory >>>>>>>> Traceback (most recent call last): >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/webapi/resources.py", >>>>>>>> line 1510, in create >>>>>>>> request.FILES.get('parent_diff_path')) >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/reviews/forms.py", >>>>>>>> line 295, in create >>>>>>>> history) >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/diffviewer/forms.py", >>>>>>>> line 84, in create >>>>>>>> diff_file, basedir, check_existance=(not parent_diff_file))) >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/diffviewer/forms.py", >>>>>>>> line 170, in _process_files >>>>>>>> not self.repository.get_file_exists(filename, revision))): >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/scmtools/models.py", >>>>>>>> line 169, in get_file_exists >>>>>>>> return self.get_scmtool().file_exists(path, revision) >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/scmtools/core.py", >>>>>>>> line 72, in file_exists >>>>>>>> self.get_file(path, revision) >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/scmtools/perforce.py", >>>>>>>> line 306, in get_file >>>>>>>> return self.client.get_file(path, revision) >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/scmtools/perforce.py", >>>>>>>> line 224, in get_file >>>>>>>> return self._run_worker(lambda: self._get_file(path, revision)) >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/scmtools/perforce.py", >>>>>>>> line 154, in _run_worker >>>>>>>> result = worker() >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/scmtools/perforce.py", >>>>>>>> line 224, in <lambda> >>>>>>>> return self._run_worker(lambda: self._get_file(path, revision)) >>>>>>>> File >>>>>>>> "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.9-py2.7.egg/reviewboard/scmtools/perforce.py", >>>>>>>> line 201, in _get_file >>>>>>>> stderr=subprocess.PIPE) >>>>>>>> File "/usr/local/lib/python2.7/subprocess.py", line 679, in >>>>>>>> __init__ >>>>>>>> errread, errwrite) >>>>>>>> File "/usr/local/lib/python2.7/subprocess.py", line 1228, in >>>>>>>> _execute_child >>>>>>>> raise child_exception >>>>>>>> OSError: [Errno 2] No such file or directory >>>>>>>> 2012-08-06 00:25:50,140 - DEBUG - Attempting authentication on API >>>>>>>> for user nileshj >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Aug 6, 2012 at 1:07 PM, Christian Hammond < >>>>>>>> chip...@chipx86.com> wrote: >>>>>>>> >>>>>>>>> Can you find anything in reviewboard.log that starts with "Error >>>>>>>>> uploading new diff" ? That's the most likely trigger for this error. >>>>>>>>> >>>>>>>>> >>>>>>>>> Christian >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Christian Hammond - chip...@chipx86.com >>>>>>>>> Review Board - http://www.reviewboard.org >>>>>>>>> VMware, Inc. - http://www.vmware.com >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, Aug 6, 2012 at 12:33 AM, Nilesh Jaiswal < >>>>>>>>> nileshj...@gmail.com> wrote: >>>>>>>>> >>>>>>>>>> Thank for prompt reply. Your reply motivated me. I think you will >>>>>>>>>> provide me solution after looking into the requested diff. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Here is the requested output. The line marked with red have been >>>>>>>>>> added to file. >>>>>>>>>> >>>>>>>>>> posting review request... >>>>>>>>>> >>> RBTools 0.3.4 >>>>>>>>>> >>> Home = /home/nileshj >>>>>>>>>> >>> svn info >>>>>>>>>> >>> p4 info >>>>>>>>>> >>> repository info: Path: pf-ch.nds.com:1666, Base path: None, >>>>>>>>>> Supports changesets: True >>>>>>>>>> >>> HTTP GETting api/ >>>>>>>>>> >>> HTTP GETting http://rbc.nds.com:8000/rbsvr/api/info/ >>>>>>>>>> >>> Using the new web API >>>>>>>>>> >>> Generating diff for changenum 1568 >>>>>>>>>> >>> p4 describe -s 1568 >>>>>>>>>> >>> CREATING WHERE FILE FROM /tmp/tmpMhEcPa >>>>>>>>>> >>> p4 -ztag -x /tmp/tmpMhEcPa where >>>>>>>>>> >>> Processing edit of >>>>>>>>>> //dator/Dev/DEV_BR/Plugins/PostPlugin/SConscript >>>>>>>>>> >>> WRITING //dator/Dev/DEV_BR/Plugins/PostPlugin/SConscript#1 >>>>>>>>>> to /tmp/tmp_yDlEz >>>>>>>>>> >>> CREATING OLD PRINT BATCH /tmp/tmp26cwU1 >>>>>>>>>> >>> p4 -s -p pf-ch.nds.com:1666 -x /tmp/tmp_yDlEz print >>>>>>>>>> >>> CREATING NEW PRINT BATCH /tmp/tmp5APfF- >>>>>>>>>> >>> p4 -s -p pf-ch.nds.com:1666 -x /tmp/tmpxe11Ch print >>>>>>>>>> >>> Processing edit of >>>>>>>>>> //dator/Dev/DEV_BR/Plugins/PostPlugin/SConscript >>>>>>>>>> >>> Writing "//dator/Dev/DEV_BR/Plugins/PostPlugin/SConscript#1" >>>>>>>>>> to "/tmp/tmpnNHcoH" >>>>>>>>>> >>> diff -urNp /tmp/tmpnNHcoH >>>>>>>>>> /home/nileshj/fwei///dator/Dev/DEV_BR/Plugins/PostPlugin/SConscript >>>>>>>>>> --- //dator/Dev/DEV_BR/Plugins/PostPlugin/SConscript >>>>>>>>>> //dator/Dev/DEV_BR/Plugins/PostPlugin/SConscript#1 >>>>>>>>>> +++ //dator/Dev/DEV_BR/Plugins/PostPlugin/SConscript >>>>>>>>>> 2012-08-06 14:50:29 >>>>>>>>>> @@ -18,6 +18,6 @@ env.InstallTree( "DeclarativeFiles", ".. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> #====================================================================== >>>>>>>>>> -* >>>>>>>>>> +#=====* >>>>>>>>>> retval = env.ProcessDir(env_base) >>>>>>>>>> Return('retval') >>>>>>>>>> >>>>>>>>>> Thank you again. >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Nilesh >>>>>>>>>> >>>>>>>>>> On Mon, Aug 6, 2012 at 12:52 PM, Christian Hammond < >>>>>>>>>> chip...@chipx86.com> wrote: >>>>>>>>>> >>>>>>>>>>> On Sun, Aug 5, 2012 at 11:21 PM, Nilesh Jaiswal < >>>>>>>>>>> nileshj...@gmail.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Dear All, >>>>>>>>>>>> >>>>>>>>>>>> I am trying to post the review request as below argument. >>>>>>>>>>>> >>>>>>>>>>>> My perforce id:njaiswal >>>>>>>>>>>> >>>>>>>>>>>> *I am using --submit-as option.* >>>>>>>>>>>> >>>>>>>>>>>> *post-review --bugs-closed="TEST" --file-list=/tmp/tmp9Dj3Dt >>>>>>>>>>>> --branch="DEV_BR" >>>>>>>>>>>> --server=http://rbc.nds.com:8000/rbsvr--submit-as=nileshj >>>>>>>>>>>> --description-file="/tmp/tmp79D4Hj" 1567 --p4-port=" >>>>>>>>>>>> pf-ch.nds.com:1666"* >>>>>>>>>>>> >>>>>>>>>>>> My while posting i am getting below error message. >>>>>>>>>>>> >>>>>>>>>>>> FOR RB USE DO NOT EDIT >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> It looks like you're using a custom post-review script. We can't >>>>>>>>>>> fully support that, but I'll try to answer your questions. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> ---------------------- >>>>>>>>>>>> p4web link: http://pf-ch.nds.com:5500/1567?ac=10 >>>>>>>>>>>> baseline: 1564 >>>>>>>>>>>> ' for review request '3' >>>>>>>>>>>> >>> HTTP PUTting to >>>>>>>>>>>> http://rbc.nds.com:8000/rbsvr/api/review-requests/3/draft/: >>>>>>>>>>>> {'description': 'RB testing for china \n\n\nFOR RB USE DO NOT >>>>>>>>>>>> EDIT\n----------------------\np4web link: >>>>>>>>>>>> http://pf-ch.nds.com:5500/1567?ac=10\nbaseline: 1564\n'} >>>>>>>>>>>> >>> Uploading diff, size: 159 >>>>>>>>>>>> >>> HTTP POSTing to >>>>>>>>>>>> http://rbc.nds.com:8000/rbsvr/api/review-requests/3/diffs/: {} >>>>>>>>>>>> >>> Got API Error 105 (HTTP code 400): One or more fields had >>>>>>>>>>>> errors >>>>>>>>>>>> >>> Error data: {u'fields': {u'path': [u'[Errno 2] No such file >>>>>>>>>>>> or directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more >>>>>>>>>>>> fields >>>>>>>>>>>> had errors', u'code': 105}} >>>>>>>>>>>> Your review request still exists, but the diff is not attached. >>>>>>>>>>>> >>>>>>>>>>>> *My question is, * >>>>>>>>>>>> >>>>>>>>>>>> 1. Does my RB server user id requires account in perforce? >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> No. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> 2. What should i do make posting of review request if am having >>>>>>>>>>>> one perforce id with multiple RB server user id. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> All you need is one Perforce ID that's configured in the >>>>>>>>>>> repository settings. The Review Board users have nothing to do with >>>>>>>>>>> Perforce users. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> 3. Is it mandatory that perforce id to be in the user list of >>>>>>>>>>>> reviewboard server >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> No. It wouldn't matter in any way. >>>>>>>>>>> >>>>>>>>>>> It sounds like there's just something wrong with your diff. Run >>>>>>>>>>> that command with --output-diff and inspect the output. Also, check >>>>>>>>>>> your >>>>>>>>>>> reviewboard.log for errors that correspond to the time you made that >>>>>>>>>>> request. >>>>>>>>>>> >>>>>>>>>>> Christian >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Christian Hammond - chip...@chipx86.com >>>>>>>>>>> Review Board - http://www.reviewboard.org >>>>>>>>>>> VMware, Inc. - http://www.vmware.com >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Want to help the Review Board project? Donate today at >>>>>>>>>>> http://www.reviewboard.org/donate/ >>>>>>>>>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>>>>>>>>> -~----------~----~----~----~------~----~------~--~--- >>>>>>>>>>> To unsubscribe from this group, send email to >>>>>>>>>>> reviewboard+unsubscr...@googlegroups.com >>>>>>>>>>> For more options, visit this group at >>>>>>>>>>> http://groups.google.com/group/reviewboard?hl=en >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Want to help the Review Board project? Donate today at >>>>>>>>>> http://www.reviewboard.org/donate/ >>>>>>>>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>>>>>>>> -~----------~----~----~----~------~----~------~--~--- >>>>>>>>>> To unsubscribe from this group, send email to >>>>>>>>>> reviewboard+unsubscr...@googlegroups.com >>>>>>>>>> For more options, visit this group at >>>>>>>>>> http://groups.google.com/group/reviewboard?hl=en >>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Want to help the Review Board project? Donate today at >>>>>>>>> http://www.reviewboard.org/donate/ >>>>>>>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>>>>>>> -~----------~----~----~----~------~----~------~--~--- >>>>>>>>> To unsubscribe from this group, send email to >>>>>>>>> reviewboard+unsubscr...@googlegroups.com >>>>>>>>> For more options, visit this group at >>>>>>>>> http://groups.google.com/group/reviewboard?hl=en >>>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Want to help the Review Board project? Donate today at >>>>>>>> http://www.reviewboard.org/donate/ >>>>>>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>>>>>> -~----------~----~----~----~------~----~------~--~--- >>>>>>>> To unsubscribe from this group, send email to >>>>>>>> reviewboard+unsubscr...@googlegroups.com >>>>>>>> For more options, visit this group at >>>>>>>> http://groups.google.com/group/reviewboard?hl=en >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Want to help the Review Board project? Donate today at >>>>>>> http://www.reviewboard.org/donate/ >>>>>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>>>>> -~----------~----~----~----~------~----~------~--~--- >>>>>>> To unsubscribe from this group, send email to >>>>>>> reviewboard+unsubscr...@googlegroups.com >>>>>>> For more options, visit this group at >>>>>>> http://groups.google.com/group/reviewboard?hl=en >>>>>>> >>>>>> >>>>>> -- >>>>>> Want to help the Review Board project? Donate today at >>>>>> http://www.reviewboard.org/donate/ >>>>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>>>> -~----------~----~----~----~------~----~------~--~--- >>>>>> To unsubscribe from this group, send email to >>>>>> reviewboard+unsubscr...@googlegroups.com >>>>>> For more options, visit this group at >>>>>> http://groups.google.com/group/reviewboard?hl=en >>>>>> >>>>> >>>>> -- >>>>> Want to help the Review Board project? Donate today at >>>>> http://www.reviewboard.org/donate/ >>>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>>> -~----------~----~----~----~------~----~------~--~--- >>>>> To unsubscribe from this group, send email to >>>>> reviewboard+unsubscr...@googlegroups.com >>>>> For more options, visit this group at >>>>> http://groups.google.com/group/reviewboard?hl=en >>>>> >>>> >>>> -- >>>> Want to help the Review Board project? Donate today at >>>> http://www.reviewboard.org/donate/ >>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>> -~----------~----~----~----~------~----~------~--~--- >>>> To unsubscribe from this group, send email to >>>> reviewboard+unsubscr...@googlegroups.com >>>> For more options, visit this group at >>>> http://groups.google.com/group/reviewboard?hl=en >>>> >>> >>> -- >>> Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> -~----------~----~----~----~------~----~------~--~--- >>> To unsubscribe from this group, send email to >>> reviewboard+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >>> >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
