Hi Stephen,

We have support for that working in the 1.7 betas. 1.6 won't get it, as it
required some rewrites I don't feel comfortable backporting at this time.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Oct 17, 2012 at 8:20 AM, Stephen Bash <scb...@gmail.com> wrote:

> Hi all-
>
> After upgrading to 1.6.12 last week, I finally got around to updating my
> Git hook script to detect renames and send them to RB.  Unfortunately it
> looks like pure renames don't post correctly.  For example, I generated a
> trivial commit with a single rename:
>
> 9e22aa0f7b20d658147046e7f1cc40f0b89a2ee3
> diff --git a/SConscript b/foo
> similarity index 100%
> rename from SConscript
> rename to foo
>
> The hook script gathers up the commit summary, description, and the above
> diff and then calls
>
> post-review --publish --summary=... --description=... --diff-filename=-
>
> At that point post-review warns of a malformed diff, the review is
> created, but left in draft form.  I also tested a move plus an edit of the
> moved file, and that posts correctly.  I didn't think to test a move of one
> file and an edit of a different one...
>
> Is this a bug that can be fixed, or is there perhaps a workaround I can
> use in the hook script?
>
> Thanks,
> Stephen
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to