Yes, each ReviewBoard hardcodes a required version of Djblets. See setup.py for 
the dependency list.

The latest 1.6.x release introduced support for SVN properties, so I suspect 
you'll have more luck when that release is installed.

Christian


On Oct 17, 2012, at 8:21, Neil Bird <fnx...@gmail.com> wrote:

> 
> 
> On Tuesday, 16 October 2012 21:13:48 UTC+1, Christian Hammond  wrote:
>> 
>> That's the wrong humanize.
>> Your Djblets wasn't updated along with Review Board, which is the problem. 
>> You need to update that package too.
> 
> Not sure I follow;  is that ReviewBoard release tied to a specific version of 
> this Djblets then?  I have Djblets 0.6.22.
> 
> 
>> Can you run that post-review command but with --output-diff and show the 
>> headers of that file where it lists the filenames?
>> I imagine post-review in this case is choosing the wrong base path.
> 
> Not sure if this is what you were planning on looking for, but I've 
> discovered the basic cause of the issue, if not the  problem.  It's that 
> post-review issues svn diff --diff-cmd=diff.
> 
> This causes a change in the output (possibly a diff/patch corruption) for (at 
> least) new files with svn properties set.  If I run post-review with the 
> given diff as created by the post-review command, it fails.  If I do the 
> same, but create the diff without the --diff-cmd it works.
> 
> Example snippet of failing output (the diff that post-review would create):
> 
> +#endif /* TREE_CELLEDIT_H */
> +
> Index: trunk/Source/Framework/Gui/Tree/TreeEdit.h
> ===================================================================
> --- trunk/Source/Framework/Gui/Tree/TreeEdit.h    (revision 12566)
> +++ trunk/Source/Framework/Gui/Tree/TreeEdit.h    (revision 12567)
> 
> Property changes on: trunk/Source/Framework/Gui/Tree/TreeEdit.h
> ___________________________________________________________________
> Added: svn:eol-style
> ## -0,0 +1 ##
> +LF
> \ No newline at end of property
> 
> Example snippet of working output:
> 
> +#endif /* TREE_CELLEDIT_H */
> +
> 
> Property changes on: trunk/Source/Framework/Gui/Tree/TreeEdit.h
> ___________________________________________________________________
> Added: svn:eol-style
> ## -0,0 +1 ##
> +LF
> \ No newline at end of property
> 
> But I can't comment of the rightness or wrongness of either input or 
> processing.
> 
> I'll have to see if I can nobble my post-review to not issue that option, or 
> wrap it such that I do the diff manually & pass it in as a file.
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to