It's correct to upload full diffs. The best way to do this is to use the
post-review tool, which (with no arguments) will do the right thing.

-David


-David


On Fri, Nov 30, 2012 at 2:49 PM, Will <ultraran...@gmail.com> wrote:

> So... don't any users know how whether it's correct to upload full diffs
> or partial diffs?
>
>
>
> On Thursday, 22 November 2012 12:44:25 UTC, Will wrote:
>>
>> Where is it described in the documentation the correct way to make
>> several diffs and upload them incrementally?
>>
>> We had a situation where one of our developers only uploaded partial
>> diffs each time (just the changes since the last time he uploaded a diff),
>> meaning there was no way to see his complete set of diffs together.
>> I don't blame him because how was he supposed to know not to do that?
>> We ended up hacking some extra instructions into the "add review"
>> template and marking them bold red to try and prevent people doing this.
>>
>> ReviewBoard assumes all diffs are complete (from first commit to last),
>> and it figures out the rest, allowing reviewers to easily drill down by
>> revision if they want.
>> If any of the uploaded diffs are not complete, then reviewers can
>> completely miss changes that were made.
>>
>> a) where is the "right" way to add diffs documented?
>>
>> b) shouldn't reviewboard make it a lot more difficult to upload diffs
>> "wrongly"
>>
>>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Reply via email to