Satish,

If you'd like to backport it,
https://github.com/reviewboard/reviewboard/commit/84c42014dafd8be04a2dc34bc0fea56663777176was
my change to fix the last issue. That said, I think there are other
related issues in 1.6.3. We highly recommend just upgrading to the new
1.6.15, which has this fix and others.

-David


-David



On Sun, Dec 16, 2012 at 10:34 PM, satish singh <trivi...@gmail.com> wrote:

> Hi David,
>
> I have seen the module "'reviewboard.reviews.models'" , I put some debug
> statements and found that the save method is not called with
> update_counts=True, when we  discarded a unpublished review and again
> publish a review with same change no. It calls the save method but the
> update_counts is false.
>
>
>  def save(self, update_counts=False, **kwargs):
>         self.bugs_closed = self.bugs_closed.strip()
>         self.summary = truncate(self.summary, MAX_SUMMARY_LENGTH)
>
>         if update_counts or self.id is None:
>             self._update_counts()
>
>         if self.status != self.PENDING_REVIEW:
>             # If this is not a pending review request now, delete any
>             # and all ReviewRequestVisit objects.
>             self.visits.all().delete()
>
>         super(ReviewRequest, self).save(**kwargs)
>
>
> Please give me some pointer on how to fix this issue.
>
>
>
> On Thursday, 13 December 2012 11:03:38 UTC+5:30, David Trowbridge wrote:
>
>> I think we still have a lingering bug when reopening existing review
>> requests. I'll look into it.
>>
>> In the meantime, you can run the "fixreviewcounts" management command to
>> fix these.
>>
>> -David
>>
>>
>> -David
>>
>>
>>
>> On Wed, Dec 12, 2012 at 9:30 PM, satish singh <triv...@gmail.com> wrote:
>>
>>>  can any one give me a pointer on this pls.
>>>
>>>
>>> On Wednesday, 12 December 2012 15:49:51 UTC+5:30, satish singh wrote:
>>>>
>>>> I am running on Review Board 1.6.3.
>>>>
>>>> Say the outgoing review count is 10.
>>>>
>>>> When i post a review through GUI with a change no, the outgoing review
>>>> count is increased by 1 that is 11, and then i discard it before 
>>>> publishing.
>>>> The outgoing review count is decreased by 1, that is 10.
>>>> Now again publish a review with same change no. the outgoing review
>>>> count is not increased this time. and remain 10.
>>>> if i repeat this 10 more time, the outgoing review count becomes
>>>> negative.
>>>>
>>>>
>>>  --
>>> Want to help the Review Board project? Donate today at
>>> http://www.reviewboard.org/**donate/<http://www.reviewboard.org/donate/>
>>> Happy user? Let us know at 
>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/>
>>> -~----------~----~----~----~--**----~----~------~--~---
>>> To unsubscribe from this group, send email to reviewboard...@**
>>> googlegroups.com
>>>
>>> For more options, visit this group at http://groups.google.com/**
>>> group/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en>
>>>
>>>
>>>
>>
>>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Reply via email to