Hi Brian,

Just to sanity check, when you run that manually, is it also using Python
2.6?

It seems weird that we'd be able to import that file but not get the
version. In my copy here, it's nothing but a straight-forward variable
assignment in a file called __version__.py.

It'd be interesting to add some logging there to print
mercurial.__version__.__file__ and then look in there to see what it says.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Jan 3, 2013 at 7:55 AM, Brian Armstrong <kf7...@gmail.com> wrote:

> Since upgrading to 1.7.1 all new reviews have been running into this issue
> (backtrace below).
>
> I did some digging into the traceback that was generated and found the
> following:
>
> reviewboard/scmtools/hg.py line 215, the "version" variable being passed
> to parse_version is None.
> This is coming from line 213 "from mercurial.__version__ import version"
>
> When I run the line above from the command line I get back "1.9", but for
> some reason it is not working from the web server.
>
> I have not changed any set up with the web server since upgrading from
> 1.6.13 to 1.7.1, but this wasn't an issue before.
>
> I have verified the rb-site was properly upgraded.
>
> Is there something I missed somewhere? To get it to work in the mean time
> I hardcoded the version number for mercurial, which seems to have mitigated
> the issue (and made me feel really dirty), but I'm still not sure why it
> thinks it should break itself.
>
>
> Traceback (most recent call last):
>
>   File
> "/usr/lib/python2.6/site-packages/Django-1.4.3-py2.6.egg/django/core/handlers/base.py",
> line 111, in get_response
>     response = callback(request, *callback_args, **callback_kwargs)
>
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-1.7.1-py2.6.egg/reviewboard/accounts/decorators.py",
> line 20, in _check
>     return login_required(view_func)(*args, **kwargs)
>
>   File
> "/usr/lib/python2.6/site-packages/Djblets-0.7.8-py2.6.egg/djblets/auth/util.py",
> line 47, in _checklogin
>     return view_func(request, *args, **kwargs)
>
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-1.7.1-py2.6.egg/reviewboard/reviews/views.py",
> line 728, in review_detail
>     'screenshots': screenshots,
>
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-1.7.1-py2.6.egg/reviewboard/reviews/views.py",
> line 124, in _make_review_request_context
>     upload_diff_form = UploadDiffForm(review_request)
>
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-1.7.1-py2.6.egg/reviewboard/reviews/forms.py",
> line 276, in __init__
>     data, *args, **kwargs)
>
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-1.7.1-py2.6.egg/reviewboard/diffviewer/forms.py",
> line 51, in __init__
>     if self.repository.get_scmtool().get_diffs_use_absolute_paths():
>
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-1.7.1-py2.6.egg/reviewboard/scmtools/models.py",
> line 134, in get_scmtool
>     return cls(self)
>
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-1.7.1-py2.6.egg/reviewboard/scmtools/hg.py",
> line 31, in __init__
>     self.client = HgClient(repository.path, repository.local_site)
>
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-1.7.1-py2.6.egg/reviewboard/scmtools/hg.py",
> line 215, in __init__
>     if parse_version(version) <= parse_version("1.2"):
>
>   File
> "/usr/lib/python2.6/site-packages/distribute-0.6.30-py2.6.egg/pkg_resources.py",
> line 1984, in parse_version
>     for part in _parse_version_parts(s.lower()):
>
> TypeError: 'NoneType' object is not callable
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Reply via email to