Hi, Can you please suggest what wrong i am doing when trying svn hook in post-commit. When i try this command - diff gets uploaded to reviewboard under but when try same from svn hooks it fails. what am i missing. what needs to be done with cookie?
/opt/Python-2.7.3/bin/python /opt/Python-2.7.3/bin/post-review --server=http://codereview.mt.com -repository-url=svnrepo-navision --username=admin --password=admin --review-request-id=162 -p On Friday, October 15, 2010 2:42:18 PM UTC+5:30, Gauthier Segay wrote: > > Hi, I'm looking for help diagnosing issue I have with empty review > entries being created. > > here is the laydown of my setup: > > * svn server is running on a windows box with SYSTEM account > * I intend using svn 'post commit' hook to create new review request > for each commit, using post-review script and python 2.7 > * reviewboard 1.0.9 is running on a gentoo box > > here is the content of post-commit.bat (svn hook): > ====================== > cd to location containing .post-review-cookies.txt > set /a revisiontopost=%2 -1 > c:\python27\scripts\post-review --server http://reviewboard.lcgentoo.local > --revision-range %revisiontopost% --repository-url svn://192.168.1.7 -- > debug --username xxx --password yyy >> path\to\some\post-review.log > ====================== > > here is what I get in the output log: > ====================== > >>> svn info svn://192.168.1.7 > >>> diff --version > >>> repository info: Path: svn://192.168.1.7, Base path: /, Supports > changesets: False > >>> svn diff --diff-cmd=diff svn://192.168.1.7/@5324 svn:// > 192.168.1.7/@HEAD > >>> Looking for 'reviewboard.lcgentoo.local /' cookie in > .post-review-cookies.txt > >>> Loaded valid cookie -- no login required > >>> HTTP GETting /api/json/repositories/ > >>> svn info svn://192.168.1.7 > >>> diff --version > >>> repository info: Path: svn://192.168.1.7, Base path: /, Supports > changesets: False > >>> svn diff --diff-cmd=diff svn://192.168.1.7/@5325 svn:// > 192.168.1.7/@HEAD > >>> Looking for 'reviewboard.lcgentoo.local /' cookie in > .post-review-cookies.txt > >>> Loaded valid cookie -- no login required > >>> HTTP GETting /api/json/repositories/ > >>> HTTP GETting /api/json/repositories/1/info/ > >>> repository info: Path: svn://192.168.1.7, Base path: /, Supports > changesets: False > >>> Attempting to create review request on svn://192.168.1.7 for None > >>> HTTP POSTing to > http://reviewboard.lcgentoo.local/api/json/reviewrequests/new/: > {'repository_path': 'svn://192.168.1.7'} > >>> Review request created > >>> Uploading diff, size: 556 > >>> HTTP POSTing to > http://reviewboard.lcgentoo.local/api/json/reviewrequests/10/diff/new/: > {'basedir': '/'} > Review request #10 posted. > > http://reviewboard.lcgentoo.local/r/10 > ====================== > > then when I go to http://reviewboard.lcgentoo.local/r/10 and click on > 'View Diff' button, a page displays > > """ > The page you were looking for does not exist. > > If you're pretty sure this page does exist, try logging in and trying > again. > """ > > from the output log (>>> Uploading diff, size: 556), I would think > it's going ok and don't know what to look for. > > Anyone can help with that? > > I'd also like to describe the issues I've run into that I think should > be mentionned in the documentation even if that doesn't necessarily > involve reviewboard, but svn: > > 1: how to get SYSTEM account to access svn while not being able to > pass svn credentials to post-review script? > > for this issuing a svn info with credentials just before running post- > review was sufficient, I know it's mostly a svn issue but stating > these elements in post-review documentation would probably help lost > sheep: > * that CVS specific credentials are not passed to post-review for some > particular reason > * for svn, issuing a 'svn info' command with credentials is generally > persisting those credentials > * add more help for other CVS > > 2: >>> Couldn't load cookie file: [Errno 2] No such file or directory: > '.post-review-cookies.txt' > > I've found a post on this group relating this issue, I think it should > be mentioned that for windows user, they would have to workaround by > issuing a cd command to the folder containing this file. > > This file was created when I tried post-review by hand, but on windows > I can't login to a shell with SYSTEM (or NETWORK SERVICE) user account > (or still need to learn how to do so) making solving this not straight > forward. > > In anycase thanks for great code review tool, I hope we'll use it soon > as our default code review tool, and that I would be able to easily > upgrade the installed version on our server. > > Thanks for your support -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
