Hi Sundeep,
Using the uri-templates on the root relies on functionality specific to the
root resource. The way the API Client knows it can do this is based on the
Content-Type header the server returns when you request the root resource.
Could you please show me the header output of:
curl -i http://<your-RB-url>/api/
Thanks,
Steven
On Mon, May 27, 2013 at 2:25 PM, soorajchirag <contact.sund...@gmail.com>wrote:
> Hi Steven,
>
> I am attempting to get the review request by using the following as you
> stated in your email:
> root.get_review_request(**review_request_id=15583)
>
> but it failed for me with the same AttributeError as in this thread.
>
> However, when I tried the other approach in your mail, it works fine.
>
> The following works:
> self.review_request_id = id
> self.review_request = self.root.get_review_requests().get_item(id)
>
> This one doesnt:
> self.review_request_id = id
> self.review_request =
> self.root.get_review_request(review_request_id=id)
>
> Error:
> File ".../common/interface.py", line 95, in set_review_id
> self.review_request =
> self.root.get_review_request(review_request_id=str_id)
> File ".../rbtools/api/resource.py", line 273, in __getattr__
> raise AttributeError
>
> I tried get_diffs() as well and that is also failing with the same error.
>
> Is there something I need to do differently?
>
> Regards,
> Sundeep
>
> On Tuesday, 21 May 2013 00:37:08 UTC+5:30, Steven MacLeod wrote:
>
>> Hi,
>>
>> 'root.get_review_requests().**get_self(id='15583',
>> repository=repository)' will result in a
>> "GET http://.../api/review_**requests/?id=15583&repository=**<id>"
>>
>> What you're looking for is 'root.get_review_requests().**get_item(15583)',
>> or alternatively 'root.get_review_request(**review_request_id=15583).
>> The former traverses the tree of resources, while the latter uses the root
>> resource's uri-template for 'review-request'.
>>
>> Additionally, retrieving the id of the repository is unnecessary to find
>> the review request with the ID you are looking for.
>>
>>
>> On Mon, May 20, 2013 at 8:50 AM, Dave Johnston <dave.j...@me.com> wrote:
>>
>>> Hi,
>>>
>>> I've been trying to following the documentation here:
>>> http://www.reviewboard.org/**docs/rbtools/0.5/api/tutorial/<http://www.reviewboard.org/docs/rbtools/0.5/api/tutorial/>
>>>
>>> To create a review for a existing review request, and then add a comment
>>> to the review. Unfortunately I'm not getting far.
>>> I've tried the following:
>>>
>>> root = client.get_root()
>>> repos = root.get_repositories()
>>> if repos.num_items < 1:
>>> raise Exception('No valid repositories.')
>>>
>>> repository = repos[0].id
>>> review_request = root.get_review_requests().**get_self(id='15583',
>>> repository=repository)
>>> review = review_request.get_reviews().**create()
>>> filediff_id = review.get_diffs()[0].get_**files()[0].id
>>> review.get_diff_comments().**create(
>>> filediff_id=1,
>>> first_line=131,
>>> num_lines=2,
>>> text='This is a diff comment!')
>>>
>>> review.update(body_top='Test Review Comment - please ignore',
>>> public=True)
>>>
>>> I get the error: AttributeError: 'ResourceList' object has no attribute
>>> 'get_reviews'
>>>
>>> So it looks like root.get_review_requests().**get_self(id='15583',
>>> repository=repository) isn't the right request to return an existing review
>>> request ?
>>> Any help would be much appreciated.
>>>
>>> Cheers
>>>
>>> --
>>> Want to help the Review Board project? Donate today at
>>> http://www.reviewboard.org/**donate/<http://www.reviewboard.org/donate/>
>>> Happy user? Let us know at
>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/>
>>> -~----------~----~----~----~--**----~----~------~--~---
>>> To unsubscribe from this group, send email to reviewboard...@**
>>> googlegroups.com
>>>
>>> For more options, visit this group at http://groups.google.com/**
>>> group/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en>
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@**googlegroups.com.
>>>
>>> For more options, visit
>>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
>>> .
>>>
>>>
>>>
>>
>> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
