New user to ReviewBoard here. Great tool with an intuitive interface, 
thanks for your efforts! Recently, one of my users was using 'rbt' from 
RBTools 0.5.1 and noticed that it would not accept '~' in the value for 
--diff-filename. My guess was that rbt does not run os.path.expanduser on 
the value, so I modified rbtools/commands/post.py with the following:
--- orig/rbtools/commands/post.py       2013-05-30 00:36:44.000000000 -0700
+++ RBTools-0.5.1.1-py2.7.egg/rbtools/commands/post.py  2013-06-11 
15:33:05.449908000 -0700
@@ -455,8 +455,11 @@
                 diff = sys.stdin.read()
             else:
                 try:
-                    diff_path = os.path.join(origcwd,
-                                             self.options.diff_filename)
+                    if (self.options.diff_filename.startswith('~')):
+                       diff_path = 
os.path.expanduser(self.options.diff_filename)
+                    else:
+                        diff_path = os.path.join(origcwd,
+                                                 
self.options.diff_filename)
                     fp = open(diff_path, 'r')
                     diff = fp.read()
                     fp.close()

My question is, is this sufficient to fix the problem or are there more 
places where I need to run expanduser? Also, although debug output 
indicates that it is unable to open the file, running rbt in normal mode is 
silent about not being able to find the difffile. Thanks!!!

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to