Hi,

I have made a new release to fix the missing template problem and also some 
other small problems:

Send message to all receivers over the same connection
Added configuration for connection timeout
Added configuration for tls verify peer self-signed certificate
Improved logging


One of the side effects of using one connection for each receive was that 
the message was sent several times :( This should be fixed now.


Horatiu

On Monday, May 20, 2013 6:01:31 PM UTC+2, Adam wrote:
>
> Hi,
>
> I just tried installing this (easy_install) and ran into some problems 
> after configuration:
>
> 1. I noticed it added a new (broken) link to the dashboard which (when 
> clicked) gives a traceback ending with
>
> TemplateDoesNotExist: rbxmppnotification/dashboard.html
>
> Is this link supposed to exist?
>
> 2. With regards the actual sending of Jabber messages, I get some nasty 
> tracebacks in the reviewboard log
>
> Traceback (most recent call last):
>   File 
> "/usr/local/lib/python2.7/dist-packages/RBXmppNotification-0.2-py2.7.egg/rbxmppnotification/xmpp.py",
>  
> line 239, in send_xmpp_message
>     client.run()
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/client.py",
>  
> line 216, in run
>     self.main_loop.loop(timeout)
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/mainloop/base.py",
>  
> line 86, in loop
>     self.loop_iteration(interval)
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/mainloop/poll.py",
>  
> line 140, in loop_iteration
>     self._handlers[fileno].handle_read()
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/transport.py",
>  
> line 717, in handle_read
>     self._feed_reader(data)
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/transport.py",
>  
> line 810, in _feed_reader
>     self._reader.feed(data)
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/xmppparser.py",
>  
> line 212, in feed
>     self.parser.feed(data)
>   File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1641, in feed
>     self._parser.Parse(data, 0)
>   File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1550, in _end
>     return self.target.end(self._fixname(tag))
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/xmppparser.py",
>  
> line 158, in end
>     self._handler.stream_element(element)
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/streambase.py",
>  
> line 367, in stream_element
>     self._process_element(element)
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/streambase.py",
>  
> line 510, in _process_element
>     logger.debug("Got features element: {0}".format(serialize(element)))
>   File 
> "/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/xmppserializer.py",
>  
> line 365, in serialize
>     if _THREAD.serializer is None:
> AttributeError: 'thread._local' object has no attribute 'serializer'
>
> The "alpha2" status of pyxmpp2 worried me, so I checked out the page on 
> PyPi for other versions, and it seems to have been alpha2 since 2011-07-10! 
> My Google-fu didn't lead me to finding any fixes for this issue, so I 
> hacked around it (the serialize() was only used in logging.debug 
> statements, which I commented out. Was this working for you?
>
> With this change, it seems to now be working for me (and spamming my 
> colleagues :D)
>
> Adam
>
>
> On 18 May 2013 17:36, Horatiu Eugen VLAD <horati...@gmail.com<javascript:>
> > wrote:
>
>> Hi,
>>
>> I have open-sourced a some time ago an Instant Messaging (XMPP) extension 
>> for Review board. The feature set is basic at it just a mirroring the email 
>> notification behavior.
>>
>> Code can be downloaded from:
>>
>> https://github.com/iconoeugen/rb-xmpp-notification
>>
>> For installation follow the next steps:
>>
>>     using pip:
>>         sudo pip install RBXmppNotification
>>     using easy_install:
>>         sudo easy_install RBXmppNotification
>>     from source:
>>         git clone https://github.com/iconoeugen/rb-xmpp-notification
>>         cd RBXmppNotification
>>         sudo python setup.py build install
>> Restart your web server running review board
>> Login in to review board as administrator
>>     Go to Admin panel -> Extensions
>>     In the 'MANAGE EXTENSIONS' page, enable 'RBXmppNotification'
>>     Configure 'RBXmppNotification' with the XMPP server and sender 
>> details.
>>     Click on 'Save'
>>
>>
>> Any feedback is welcomed,
>> H
>>
>> -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~----------~----~----~----~------~----~------~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com <javascript:>
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to