I'm using RBTools 0.5.2 and I can not get rbt diff to execute correctly for 
an SVN repo.  I'm running under Windows 7 with Python 2.7.3.

Running rbt post works fine and gives me:
*rbt post -d --server http://192.168.50.xxx/reviewboard .*

DEBUG:root:Checking for a Subversion repository...
> DEBUG:root:Running: svn info --non-interactive
> DEBUG:root:Running: diff --version
> DEBUG:root:repository info: Path: http://192.168.50.yyy/svn, Base path: 
> /snip/trunk, Supports changesets: False
> DEBUG:root:Making HTTP GET request to 
> http://192.168.50.xxx/reviewboard/api/
> DEBUG:root:Making HTTP GET request to 
> http://192.168.50.xxx/reviewboard/api/info/
> DEBUG:root:Running: svn st
> DEBUG:root:Running: svn diff --diff-cmd=diff .
> DEBUG:root:Running: svn info "cpp/file.txt"
> DEBUG:root:Running: svn info cpp
> DEBUG:root:Running: svn info "cpp/file.txt"
> DEBUG:root:Running: svn info "cpp/file.txt"
> DEBUG:root:Running: svn info "cpp/file.txt"
> DEBUG:root:Making HTTP GET request to 
> http://192.168.50.xxx/reviewboard/api/review-requests/
> DEBUG:root:Making HTTP POST request to 
> http://192.168.50.xxx/reviewboard/api/review-requests/
> DEBUG:root:Making HTTP GET request to 
> http://192.168.50.xxx/reviewboard/api/review-requests/24/diffs/
> DEBUG:root:Making HTTP POST request to 
> http://192.168.50.xxx/reviewboard/api/review-requests/24/diffs/
> DEBUG:root:Making HTTP GET request to 
> http://192.168.50.xxx/reviewboard/api/review-requests/24/draft/
> Review request #24 posted.
>
> http://192.168.50.xxx/r/24/
>


Running rbt diff in the same working copy results in:
*rbt diff -d --server http://192.168.50.xxx/reviewboard .*

DEBUG:root:Checking for a Subversion repository...
> DEBUG:root:Running: svn info --non-interactive
> DEBUG:root:Running: diff --version
> DEBUG:root:repository info: Path: http://192.168.50.yyy/svn, Base path: 
> /snip/trunk, Supports changesets: False
> DEBUG:root:Making HTTP GET request to 
> http://192.168.50.xxx/reviewboard/api/
> DEBUG:root:Making HTTP GET request to 
> http://192.168.50.xxx/reviewboard/api/info/
> DEBUG:root:Running: svn st
> DEBUG:root:Running: svn diff --diff-cmd=diff .
> DEBUG:root:Running: svn info "cpp/file.txt"
> DEBUG:root:Running: svn info cpp
> DEBUG:root:Running: svn info "cpp/file.txt"
> DEBUG:root:Running: svn info "cpp/file.txt"
> DEBUG:root:Running: svn info "cpp/file.txt"
> Traceback (most recent call last):
>   File "C:\Python27\Scripts\rbt-script.py", line 9, in <module>
>     load_entry_point('RBTools==0.5.2', 'console_scripts', 'rbt')()
>   File 
> "C:\Python27\lib\site-packages\rbtools-0.5.2-py2.7.egg\rbtools\commands\main.py",
>  
> line 106, in main
>     command.run_from_argv([RB_MAIN] + args)
>   File 
> "C:\Python27\lib\site-packages\rbtools-0.5.2-py2.7.egg\rbtools\commands\__init__.py",
>  
> line 157, in run_from_argv
>     exit_code = self.main(*args) or 0
>   File 
> "C:\Python27\lib\site-packages\rbtools-0.5.2-py2.7.egg\rbtools\commands\diff.py",
>  
> line 95, in main
>     files=args)
> ValueError: need more than 1 value to unpack
>


I've tried various iterations and always get the same ValueError.  Any 
advice?

UPDATE: I dug a little deeper before submitting this post, and I've 
eliminated the error with the attached change to diff.py, but I'm not 
certain if this change will be acceptible for all SCM's?

Thanks,
Griffin

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--- C:/Python27/Lib/site-packages/RBTools-0.5.2-py2.7.egg/rbtools/commands/diff.py.orig	Thu Aug 29 10:40:24 2013
+++ C:/Python27/Lib/site-packages/RBTools-0.5.2-py2.7.egg/rbtools/commands/diff.py	Mon Sep 02 09:21:02 2013
@@ -87,7 +87,7 @@
         api_client, api_root = self.get_api(server_url)
         self.setup_tool(tool, api_root=api_root)
 
-        diff, parent_diff = get_diff(
+        diff = get_diff(
             tool,
             repository_info,
             revision_range=self.options.revision_range,

Reply via email to