I'm not sure what that would look like. Comments are over a set of rows in
the side-by-side diff rather than a set of lines from either the old or new
file. While it's possible that we could just pull out the relevant lines
from the changed revision of the file, it's likely that doing so would lose
a lot of the context for the comment. If we tried to mimic the HTML that we
show by showing columns in plain text, my instinct is that it would be very
hard to get formatted correctly, especially when mail clients wrap lines.

-David


On Thu, Sep 12, 2013 at 6:29 AM, <sankar.curios...@gmail.com> wrote:

> On Tuesday, September 10, 2013 11:16:21 AM UTC+5:30, David Trowbridge
> wrote:
>>
>> Can you define what you mean by "patch snippets"? The sections of code
>> that users comment on should be included in the HTML emails.
>>
>>
> Sorry for the late reply. Somehow did not get this email notification.
>
> The mail that I receive is not html (thankfully) and is only a plain text
> email with contents like:
>
> ===============
>
> <filename>
> <https://reviewboard-server/r/8995/#comment19850>
>
> <comment>
>
> =============
>
> whereas what I want is something like:
>
> =============
> <filename>
> > <actual code>
> <comment>
> =============
>
> Sankar
>
>
>
>> -David
>>
>>
>> On Mon, Sep 9, 2013 at 10:37 PM, <sankar.c...@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> We are using ReviewBoard in our organization. Thanks for this nice
>>> project.
>>>
>>> The reviewboard in our org is configured to send email notifications for
>>> any new patches and patch review comments. However, the review comments and
>>> the patches display a reviewboard url instead of the actual patch sources
>>> in the notification email. Is there a way to display the actual sources in
>>> the email instead of links to the review board ? (on the lines of how LKML
>>> patch reviews happen)
>>>
>>> Thanks.
>>>
>>> Sankar
>>>
>>> --
>>> Get the Review Board Power Pack at http://www.reviewboard.org/**
>>> powerpack/ <http://www.reviewboard.org/powerpack/>
>>> ---
>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>> ---
>>> Happy user? Let us know at 
>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/>
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@**googlegroups.com.
>>>
>>> For more options, visit 
>>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
>>> .
>>>
>>
>>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to