On Fri, Sep 13, 2013 at 9:01 AM, Matthew Woehlke

> On 2013-09-12 23:05, David Trowbridge wrote:
>> I'm not sure what that would look like. Comments are over a set of rows in
>> the side-by-side diff rather than a set of lines from either the old or
>> new
>> file. While it's possible that we could just pull out the relevant lines
>> from the changed revision of the file, it's likely that doing so would
>> lose
>> a lot of the context for the comment. If we tried to mimic the HTML that
>> we
>> show by showing columns in plain text, my instinct is that it would be
>> very
>> hard to get formatted correctly, especially when mail clients wrap lines.
> ...maybe using unified diff format instead of trying to do side-by-side
> could 'fix' this? (You'd lose inter-line diff, but I suppose it would be
> better than nothing.)
> --
> Matthew
If someone wrote a patch that made it work really well, I'd be open to
accepting it. I think there are going to be issues getting it work well. As
it is, our plates are too full to take this on.


Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
Happy user? Let us know at http://www.reviewboard.org/users/
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to