Created http://code.google.com/p/reviewboard/issues/detail?id=3261

Thanks.
Bruce


On Sat, Feb 22, 2014 at 8:48 PM, David Trowbridge <trowb...@gmail.com>wrote:

> Bruce,
>
> Can you file a bug about this, including the traceback?
>
> Thanks!
>
> -David
>
> On Feb 22, 2014, at 7:32 PM, Bruce Cran <bruce.c...@gmail.com> wrote:
>
> There appears to be a regression between 1.7.9 and 2.0 beta 3. I loaded a
> test machine with a snapshot of data from 1.7.9 and upgraded. Most reviews
> load fine, but on one that works on 1.7.9, with beta3 I get the exception:
>
> "UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 176:
> ordinal not in range(128)"
> It looks very similar to the problem reported (and fixed) at
> http://code.google.com/p/reviewboard/issues/detail?id=957 .
>
> I presume it's because it contains Unicode characters.
>
> 'ascii' codec can't decode byte 0xef in position 176: ordinal not in
> range(128)
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/Django-1.6.2-py2.7.egg/django/core/handlers/base.py",
> line 114, in get_response
>     response = wrapped_callback(request, *callback_args, **callback_kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/accounts/decorators.py",
> line 21, in _check
>     return login_required(view_func)(*args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/Django-1.6.2-py2.7.egg/django/contrib/auth/decorators.py",
> line 22, in _wrapped_view
>     return view_func(request, *args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/site/decorators.py",
> line 35, in _check
>     return view_func(request, local_site=local_site, *args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/reviews/views.py",
> line 649, in review_detail
>     changedesc.fields_changed[field_id])
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/reviews/fields.py",
> line 159, in get_change_entry_sections_html
>     'rendered_html': mark_safe(self.render_change_entry_html(info)),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/reviews/builtin_fields.py",
> line 395, in render_change_entry_html
>     counts = diffset.get_total_line_counts()
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/diffviewer/models.py",
> line 390, in get_total_line_counts
>     for key, value in six.iteritems(filediff.get_line_counts()):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/diffviewer/models.py",
> line 210, in get_line_counts
>     self._recalculate_line_counts(self.diff_hash)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/diffviewer/models.py",
> line 349, in _recalculate_line_counts
>     self.diffset.repository.get_scmtool())
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/diffviewer/models.py",
> line 58, in recalculate_line_counts
>     files = tool.get_parser(self.binary).parse()
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0beta3-py2.7.egg/reviewboard/scmtools/hg.py",
> line 60, in get_parser
>     if data.lstrip().startswith('diff --git'):
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 176:
> ordinal not in range(128)
>
> --
> Bruce
>
> --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>



-- 
-- 
Bruce Cran

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to