Thanks for the info. We'll get this fixed for the next releases. -David
On Thu, May 15, 2014 at 9:03 AM, Jason Woodrich <[email protected]> wrote: > Understood. Here is the output of 'cvs -f -d <cvsroot> version' with an > invalid repository path: > > $ cvs -f -d username@cvshost:/invalid/path version; echo $? > Client: Concurrent Versions System (CVS) 1.12.13 (client/server) > Server: Cannot access /invalid/path/CVSROOT > No such file or directory > 1 > > And the output using a valid repository path: > > $ cvs -f -d username@cvshost:/opt/cvs/root version; echo $? > Client: Concurrent Versions System (CVS) 1.12.13 (client/server) > Server: Concurrent Versions System (CVS) 1.11.22 (client/server) > 0 > > As you might have guessed I substituted the username and host, but the > output is the actual output from that command. > > Here's the output using a valid CVSROOT with the rls command: > $ cvs -f -d username@cvshost:/opt/cvs/root rls; echo $? > cvs [rls aborted]: server does not support rls > 1 > > On Wednesday, May 14, 2014 3:24:12 PM UTC-6, David Trowbridge wrote: > >> Actually, one question, too. >> >> Does 'cvs -f -d <cvsroot> version' actually check that the <cvsroot> is >> valid, or does it just check that the local cvs binary runs? The goal of >> this method is to verify the remote repository. >> >> -David >> >> >> On Wed, May 14, 2014 at 2:05 PM, Jason Woodrich <[email protected]>wrote: >> >>> Greetings, >>> I'm had a problem with adding a CVS repository running on CVS 1.11. I'm >>> accessing it using ssh with a key and my CVSROOT is valid. When I click >>> Save on the "Add Repository" page it returns the message "A repository was >>> not found at the specified path." This is on CentOS 6 with both >>> ReviewBoard 1.7.25 and 2.0rc3. >>> >>> I found that ReviewBoard is attempting to execute the "rls" cvs command, >>> which isn't valid until CVS 1.12, which is the 'feature' build. The >>> current stable build is 1.11.23 (according to >>> http://ftp.gnu.org/non-gnu/cvs/source/stable/). Anyone attempting to >>> add a CVS server running anything lower than 1.12 is going to fail. I >>> suspect that even if the server was 1.12 the operation would still fail if >>> the client is anything less than 1.12. >>> >>> I found the problem in /usr/lib/python2.6/site- >>> packages/ReviewBoard-2.0rc3-py2.6.egg/reviewboard/scmtools/cvs.py: >>> >>> 331 def check_repository(self): >>> 332 p = SCMTool.popen(['cvs', '-f', '-d', self.cvsroot, ' >>> *rls*'], >>> 333 self.local_site_name) >>> 334 errmsg = six.text_type(p.stderr.read()) >>> 335 if p.wait() != 0: >>> 336 raise SCMError(errmsg) >>> >>> I was able to resolve the issue by substituting 'rls' for 'version' on >>> line 332. Since ReviewBoard is just checking for the return code from CVS >>> it should function the same. >>> >>> 331 def check_repository(self): >>> 332 p = SCMTool.popen(['cvs', '-f', '-d', self.cvsroot, ' >>> *version*'], >>> 333 self.local_site_name) >>> 334 errmsg = six.text_type(p.stderr.read()) >>> 335 if p.wait() != 0: >>> 336 raise SCMError(errmsg) >>> >>> I then did a recompile (python -m compileall .) from the >>> reviewboard/scmtools directory and restarted Apache. >>> >>> Problem solved. Thought you might want to know. Your documentation >>> indicates that on RHEL/CentOS you can install CVS using "yum install cvs". >>> The version included with CentOS 6 is 1.11.23 and will not work without >>> these modifications. >>> >>> Thanks, >>> Jason >>> >>> -- >>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >>> --- >>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >>> --- >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
