On Mon, Jun 9, 2014 at 4:07 PM, Christian Hammond
> I should note that we don’t accept pull requests. All patches go through
Ah, of course. I saw
after having posted this message, should have read that first.
Apologies, of course this would be going through a Review Board
>> In rbtools/api/request.py, in PresetHTTPAuthHandler's http_request
>> method, we comment out "self.used = True", [...]
> This does not occur normally. It should retain the cookie information used
> to stay authenticated.
> Does that hook have a $HOME set? It should be some place where the
> information can be written.
I had forgotten, but we set HOME explicitly (to our /data/svn/hooks
dir) before going into the rbt post. I can confirm that it has
written .python-eggs/ and .rbtools-cookies and .subversion/ and such
there, and they look good.
I think the issue may be that this our auth layer is also _AROUND_
reviewboard; for various reasons we don't trust any of our services
and have folks log in via vhost config before even hitting RB proper:
AuthLDAPUrl "ldap://server.example.com:389/dc=example,dc=com" STARTTLS
Require ldap-group cn=internal,ou=groups,dc=example,dc=com
Options -Indexes +FollowSymLinks
Allow from all
Hence needing to always have that Basic auth_header? If it's dropped
it won't even get past apache to reviewboard at all.
> What version of Python are you using there?
> Do you ever see this problem outside the hook?
Yes; I can repro it on the command line from my personal account.
FWIW the 0.6.1 drop including the "prefer repository name" fix seems
to have fixed the other 1 or 2 issues! I'm only maintaining the
comment-out of "self.used = True" at the moment.
Responses for context, anyway:
> We strongly recommend using repository names and not URLs wherever possible.
> This provides the fastest lookup, and skips the whole issue of differences
> in URLs.
It seemed like this was the case, which is why I was trying to specify
both; if I'm understanding correctly, we must have --repository-url to
keep it from assuming a local svn working copy in cwd.
>> One other tiny note -- we've been keeping a patch over
>> reviewboard/templates/notifications that removes all the explicit
>> "font-size" (e.g. 8px, 9px, 10px) [...]
> I’d love to see screenshots of how this looks, along with a formal patch on
Will try to do this over the next few days. =)
Thanks for your help! (And thank you and all the other contributors
for all the work on Review Board, it has been a great tool for us!)
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
Happy user? Let us know at http://www.reviewboard.org/users/
You received this message because you are subscribed to the Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email
For more options, visit https://groups.google.com/d/optout.